CmdPal: make dialogs prevent compact mode from being collapsed - #49451
Open
zadjii-msft wants to merge 1 commit into
Open
CmdPal: make dialogs prevent compact mode from being collapsed#49451zadjii-msft wants to merge 1 commit into
zadjii-msft wants to merge 1 commit into
Conversation
ContentDialogs we present for CommandResult.Confirm need to be visible. When the window is clipped for compact mode, the dialog is predictably also collapsed. This makes sure that content dialogs are always visible, by forcing us out of compact mode when dialogs are shown. Closes: quite sure it was filed somewhere, right?
github-actions
Bot
added
the
Product-Command Palette
| /// the dialog is showing and <see langword="false"/> once it closes to restore the normal | ||
| /// compact/expanded behavior. | ||
| /// </summary> | ||
| public record MaximizeForDialogMessage(bool Maximize); |
Contributor
There was a problem hiding this comment.
Should this just be MaximizeWindowMessage or ForceMaximizeMessage? My thinking is that we may find other places we need to maximize for outside dialogs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ContentDialogs we present for CommandResult.Confirm need to be visible. When the window is clipped for compact mode, the dialog is predictably also collapsed.
This makes sure that content dialogs are always visible, by forcing us out of compact mode when dialogs are shown.
Closes: quite sure it was filed somewhere, right?