docs: fix missing media inputs in TechJournalist notebook#537
Closed
danyalahmed1995 wants to merge 2 commits into
Closed
docs: fix missing media inputs in TechJournalist notebook#537danyalahmed1995 wants to merge 2 commits into
danyalahmed1995 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Phi-4 multimodal TechJournalist notebook to stop relying on missing local media files by creating a local media/ folder and downloading sample image/audio assets when absent.
Changes:
- Added a setup cell that creates
media/and conditionally downloads sample image/audio viaurllib.request. - Replaced hard-coded media paths with
image_pathandaudio_pathvariables. - Updated image/audio loading cells to use the new variables.
Show a summary per file
| File | Description |
|---|---|
| md/02.Application/08.Multimodel/Phi4/TechJournalist/phi_4_mm_audio_text_publish_news.ipynb | Adds conditional media download + switches notebook loading cells to use the downloaded media paths. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (2)
md/02.Application/08.Multimodel/Phi4/TechJournalist/phi_4_mm_audio_text_publish_news.ipynb:1
- Using an MP3 sample can make this notebook fail depending on how
libsndfile/soundfileis built on the host (MP3 decoding support is not guaranteed across environments). To improve reliability, consider switching the sample audio to a WAV (or FLAC) asset known to be readable bysoundfilebroadly, or add a short note in the setup cell explaining that MP3 support may require additional system dependencies.
{
md/02.Application/08.Multimodel/Phi4/TechJournalist/phi_4_mm_audio_text_publish_news.ipynb:1
- Using an MP3 sample can make this notebook fail depending on how
libsndfile/soundfileis built on the host (MP3 decoding support is not guaranteed across environments). To improve reliability, consider switching the sample audio to a WAV (or FLAC) asset known to be readable bysoundfilebroadly, or add a short note in the setup cell explaining that MP3 support may require additional system dependencies.
{
- Files reviewed: 1/1 changed files
- Comments generated: 2
| "}\n", | ||
| "\n", | ||
| "for path, url in sample_media.items():\n", | ||
| " if not path.exists():\n", |
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
leestott
pushed a commit
that referenced
this pull request
May 13, 2026
* Initial plan * fix: address PR 537 review comments in Phi-4 journalist notebook --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #536.
This updates the Phi-4 multimodal TechJournalist notebook so the image and audio inputs no longer rely on missing local files.
Changes
media/directory.image_pathandaudio_pathvariables.Validation
./copilot.pngand./satya1.mp3references are no longer used by the loading cells.image_path,audio_path,media_dir, andurllib.requestsetup references exist.Image.open(...), andsoundfile.read(...).Note: local validation initially required installing
soundfile, then the smoke test passed after explicitly closing the image handle before temp cleanup.