Skip to content

docs: fix missing media inputs in TechJournalist notebook#537

Closed
danyalahmed1995 wants to merge 2 commits into
microsoft:mainfrom
danyalahmed1995:fix/536-techjournalist-missing-media
Closed

docs: fix missing media inputs in TechJournalist notebook#537
danyalahmed1995 wants to merge 2 commits into
microsoft:mainfrom
danyalahmed1995:fix/536-techjournalist-missing-media

Conversation

@danyalahmed1995
Copy link
Copy Markdown
Contributor

Summary

Fixes #536.

This updates the Phi-4 multimodal TechJournalist notebook so the image and audio inputs no longer rely on missing local files.

Changes

  • Adds a lightweight setup cell that creates a local media/ directory.
  • Downloads sample image/audio media only when missing.
  • Replaces the previous hard-coded missing paths with explicit image_path and audio_path variables.
  • Keeps the existing notebook flow unchanged.
  • Does not add binary files to the repo.

Validation

  • Parsed the updated notebook JSON successfully.
  • Verified the old ./copilot.png and ./satya1.mp3 references are no longer used by the loading cells.
  • Verified the new image_path, audio_path, media_dir, and urllib.request setup references exist.
  • Ran a temp-directory smoke test for download, Image.open(...), and soundfile.read(...).

Note: local validation initially required installing soundfile, then the smoke test passed after explicitly closing the image handle before temp cleanup.

@leestott leestott requested a review from Copilot May 13, 2026 09:44
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the Phi-4 multimodal TechJournalist notebook to stop relying on missing local media files by creating a local media/ folder and downloading sample image/audio assets when absent.

Changes:

  • Added a setup cell that creates media/ and conditionally downloads sample image/audio via urllib.request.
  • Replaced hard-coded media paths with image_path and audio_path variables.
  • Updated image/audio loading cells to use the new variables.
Show a summary per file
File Description
md/02.Application/08.Multimodel/Phi4/TechJournalist/phi_4_mm_audio_text_publish_news.ipynb Adds conditional media download + switches notebook loading cells to use the downloaded media paths.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (2)

md/02.Application/08.Multimodel/Phi4/TechJournalist/phi_4_mm_audio_text_publish_news.ipynb:1

  • Using an MP3 sample can make this notebook fail depending on how libsndfile/soundfile is built on the host (MP3 decoding support is not guaranteed across environments). To improve reliability, consider switching the sample audio to a WAV (or FLAC) asset known to be readable by soundfile broadly, or add a short note in the setup cell explaining that MP3 support may require additional system dependencies.
{

md/02.Application/08.Multimodel/Phi4/TechJournalist/phi_4_mm_audio_text_publish_news.ipynb:1

  • Using an MP3 sample can make this notebook fail depending on how libsndfile/soundfile is built on the host (MP3 decoding support is not guaranteed across environments). To improve reliability, consider switching the sample audio to a WAV (or FLAC) asset known to be readable by soundfile broadly, or add a short note in the setup cell explaining that MP3 support may require additional system dependencies.
{
  • Files reviewed: 1/1 changed files
  • Comments generated: 2

"}\n",
"\n",
"for path, url in sample_media.items():\n",
" if not path.exists():\n",
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
@leestott leestott closed this May 13, 2026
leestott pushed a commit that referenced this pull request May 13, 2026
* Initial plan

* fix: address PR 537 review comments in Phi-4 journalist notebook

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Phi-4 multimodal TechJournalist notebook references missing sample media files

3 participants