improvement(tree): Replace property bags with positional arguments in TableSchema APIs#27545
Open
Josmithr wants to merge 4 commits into
Open
improvement(tree): Replace property bags with positional arguments in TableSchema APIs#27545Josmithr wants to merge 4 commits into
TableSchema APIs#27545Josmithr wants to merge 4 commits into
Conversation
… TableSchema APIs
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (1245 lines, 14 files), I've queued these reviewers:
How this works
|
Contributor
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primary goal with these changes is to remove the performance overhead of the property bag objects. These APIs are intended to be called in high volumes where overhead like this can quickly add up. Additionally, in the case of these APIs, the property bag ergonomics did not end up being as valuable in terms of user experience than originally anticipated.