Skip to content

improvement(tree): Replace property bags with positional arguments in TableSchema APIs#27545

Open
Josmithr wants to merge 4 commits into
microsoft:mainfrom
Josmithr:tree/table/positional-parameters
Open

improvement(tree): Replace property bags with positional arguments in TableSchema APIs#27545
Josmithr wants to merge 4 commits into
microsoft:mainfrom
Josmithr:tree/table/positional-parameters

Conversation

@Josmithr

@Josmithr Josmithr commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

The primary goal with these changes is to remove the performance overhead of the property bag objects. These APIs are intended to be called in high volumes where overhead like this can quickly add up. Additionally, in the case of these APIs, the property bag ergonomics did not end up being as valuable in terms of user experience than originally anticipated.

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (1245 lines, 14 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

@Josmithr Josmithr marked this pull request as ready for review June 12, 2026 23:20
@Josmithr Josmithr requested review from a team as code owners June 12, 2026 23:20
Copilot AI review requested due to automatic review settings June 12, 2026 23:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

@github-actions

Copy link
Copy Markdown
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  290922 links
    1934 destination URLs
    2184 URLs ignored
       0 warnings
       0 errors


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants