Skip to content

improvement(tree): Update table row insertion/removal constraints to only specify columns with intersecting cells.#27539

Draft
Josmithr wants to merge 12 commits into
microsoft:mainfrom
Josmithr:tree/table/optimizations-2
Draft

improvement(tree): Update table row insertion/removal constraints to only specify columns with intersecting cells.#27539
Josmithr wants to merge 12 commits into
microsoft:mainfrom
Josmithr:tree/table/optimizations-2

Conversation

@Josmithr

@Josmithr Josmithr commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Update insertRows and removeRows to only specify columns for which there are existing cells as constraints.

For sparse tables, this is a pretty big win in terms of both constraint performance and usability.

Note that setCell and removeCell also have corresponding column "nodeInDocument" constraints, so the code is still robust to cell-level changes.

@Josmithr Josmithr requested a review from yann-achard-MS June 12, 2026 18:57
@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (97 lines, 1 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant