improvement(tree): Update table row insertion/removal constraints to only specify columns with intersecting cells.#27539
Draft
Josmithr wants to merge 12 commits into
Draft
Conversation
…hr/FluidFramework into tree/table/optimize-reads
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (97 lines, 1 files), I've queued these reviewers:
How this works
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
insertRowsandremoveRowsto only specify columns for which there are existing cells as constraints.For sparse tables, this is a pretty big win in terms of both constraint performance and usability.
Note that
setCellandremoveCellalso have corresponding column "nodeInDocument" constraints, so the code is still robust to cell-level changes.