Updated the client and examples release groups to use eslint-config-fluid v13.0#27530
Open
TommyBrosman wants to merge 6 commits into
Open
Updated the client and examples release groups to use eslint-config-fluid v13.0#27530TommyBrosman wants to merge 6 commits into
TommyBrosman wants to merge 6 commits into
Conversation
- Removed the no-restricted-syntax block from tree (now in the base config). - Added an ESLint suppression in one test.
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (1201 lines, 27 files), I've queued these reviewers:
How this works
|
v13.0.0 is now past the minimumReleaseAge window, so the temporary minimumReleaseAgeExclude entry is no longer needed. Regenerated the lockfile without the override.
Bumping the eslint-config-fluid catalog entry to v13 applied the new config to both the client and examples release groups (they share the pnpm catalog), surfacing new lint errors. This fixes them:
- no-only-tests: added targeted suppressions where .only is driven by test data/options (merge-tree, container-runtime, local-server-stress-tests, map).
- no-restricted-syntax: import the TypeBox Type namespace via 'import * as Type' instead of the named value export (tree-cli-app).
- @eslint-react/no-create-ref: use useRef(null) instead of createRef() in a function component (triangle-view). createRef allocated a new ref every render.
- @eslint-react/no-useless-fragment: return null instead of an empty fragment (data-object-grid).
- @eslint-react/dom/no-render: migrate ReactDOM.render to createRoot().render() (shared-tree-demo, app-insights-logger, view-framework-sampler, devtools-test-app).
- Repaired text-editor and inventory-app eslint configs that referenced the removed classic 'react' plugin, re-expressing the intended rules via @eslint-react / react-hooks.
Render-callback timing: ReactDOM.render's third callback argument does not exist on createRoot().render(). Where that callback mattered, the side effect was moved into a useLayoutEffect (runs after DOM commit, before paint) rather than firing it before the commit. flushSync is not an option (@eslint-react/dom/no-flush-sync is an error).
devtools-test-app StrictMode removal: this app initializes a singleton Devtools instance and disposes it in an effect cleanup. The original code wrapped the app in <StrictMode> while rendering via the legacy ReactDOM.render API. React 18's StrictMode setup->cleanup->setup effect double-invocation only runs under the new createRoot path; under legacy ReactDOM.render the tree stays in React-17 mode, so that check never fired and the wrapper was effectively inert for effects. Migrating to createRoot activated the double-invoke, which disposed the singleton on the simulated unmount and left later renders using a disposed instance ('The devtools instance has been disposed'). The app is not resilient to that remount cycle, so StrictMode was removed to preserve the app's actual prior behavior; making it StrictMode-safe would be a larger refactor out of scope for this change.
TommyBrosman
changed the title
alexvy86
approved these changes
Jun 12, 2026
alexvy86
left a comment
alexvy86
left a comment
Contributor
There was a problem hiding this comment.
Approving for devtools, but LGTM overall
CraigMacomber
left a comment
CraigMacomber
left a comment
Contributor
There was a problem hiding this comment.
I'm not an expert on the react code being impacted, but everything else looks good, and the react stuff seems potentially reasonable, but I'll leave its review to others.
Josmithr
reviewed
Jun 12, 2026
Josmithr
reviewed
Jun 12, 2026
Josmithr
approved these changes
Jun 12, 2026
…ols-view Address @eslint-react and unicorn rule violations surfaced by the v13 config: - blobs, devtools-view: return idiomatic null for empty render output and disable unicorn/no-null at the package level (matching data-object-grid). - example-utils, external-data: migrate deprecated ReactDOM.render to createRoot().render() and allow the react-dom/client subpath import. - devtools-view: hoist nested Recharts tick components (CustomizedXAxisTick/ CustomizedYAxisTick) to top level to satisfy @eslint-react/no-nested-component-definitions, and return ReactNode from TreeDataView so null is permitted without @rushstack/no-new-null. - data-object-grid: minor comment wording tweak.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the client release group to use
@fluidframework/eslint-config-fluidv13 (from v9) and fixes all lint errors the new config surfaces.Because the client and examples release groups share a single pnpm catalog entry for
eslint-config-fluid, bumping the catalog applies v13 to both groups. This PR therefore also fixes lint errors in the examples, not just the client release group.Lint fixes
no-only-tests— added targeted suppressions where.onlyis selected by test data/options rather than committed accidentally (merge-tree,container-runtime,local-server-stress-tests,map).no-restricted-syntax— import the TypeBoxTypenamespace viaimport * as Type from "@sinclair/typebox"instead of the named value export, which defeats tree-shaking (tree-cli-app).@eslint-react/no-create-ref— useuseRef(null)instead ofcreateRef()in a function component (triangle-view). The original allocated a new ref object every render.@eslint-react/no-useless-fragment— returnnullinstead of an empty fragment (data-object-grid).@eslint-react/dom/no-render— migrateReactDOM.rendertocreateRoot().render()(shared-tree-demo,app-insights-logger,view-framework-sampler,devtools-test-app).text-editorandinventory-appeslint configs, which referenced the removed classicreactplugin (v13 replaced it with@eslint-react), re-expressing the intended rules via@eslint-react/react-hooks.Notable behavioral details
ReactDOM.render's third callback argument has no equivalent oncreateRoot().render(). Where the callback mattered, the side effect was moved into auseLayoutEffect(runs after DOM commit, before paint) rather than firing before the commit.flushSyncis not an option (@eslint-react/dom/no-flush-syncis an error).devtools-test-appStrictMode removal: this app creates a singleton Devtools instance and disposes it in an effect cleanup. The original wrapped the app in<StrictMode>while rendering via the legacyReactDOM.renderAPI. React 18's StrictMode setup→cleanup→setup effect double-invoke only runs undercreateRoot; under legacyReactDOM.renderthe tree stays in React-17 mode, so that check never fired and the wrapper was inert for effects. Migrating tocreateRootactivated the double-invoke, which disposed the singleton on the simulated unmount and left later renders using a disposed instance (The devtools instance has been disposed). The app is not resilient to that remount cycle, so<StrictMode>was removed to preserve the app's actual prior behavior; making it StrictMode-safe would be a larger refactor out of scope here.Reviewer Guidance
data-object-grid,tree-cli-app,triangle-view(via the multiview container),app-insights-logger,shared-tree-demo,view-framework-sampler,devtools-test-app,text-editor,inventory-app.shared-tree-demowas verified without a realSPE_CLIENT_ID(the changed create-new render path does not depend on SPE).text-editor/inventory-appconfig changes drop three classic stylisticreact/*rules (jsx-boolean-value,jsx-fragments,self-closing-comp) that have no@eslint-reactequivalent. Flag if you'd prefer those preserved another way.