fix(client-test-version-utils): restore resolveRangeViaManifest behavior#27526
fix(client-test-version-utils): restore resolveRangeViaManifest behavior#27526jason-ha wants to merge 1 commit into
Conversation
Cleanup from microsoft#27521 CI repair: - restore behavior of `resolveRangeViaManifest` to only allow version that is within manifest - update unit tests to check expectations - remove `getRequestedVersion` from package exports - require `requested` be specified when calling `getRequestedVersion` - add/correct various comments Cleanup from microsoft#11082: - correct `getRequestedVersion` throwing test cases (that weren't checking error message content) - remove extraneous try-catch and wrap in `calculateRequestedRange`
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (110 lines, 3 files), I've queued these reviewers:
How this works
|
| * If the value is a negative number, the base version will be adjusted down and returned. | ||
| * If the value is 0 or `undefined`, the base version will be returned as-is. |
There was a problem hiding this comment.
Since -0 is a thing, and is a negative number, and usually considered equal to 0, and also might make sense in this code (to try and test against the most recent release, since -1 means previous beta break), we might need to clarify or rephrase this to be unambiguous on how -0 behaves.
Cleanup from #27521 CI repair:
resolveRangeViaManifestto only allow version that is within manifestgetRequestedVersionfrom package exportsrequestedbe specified when callinggetRequestedVersionCleanup from #11082:
getRequestedVersionthrowing test cases (that weren't checking error message content)calculateRequestedRange