Remove unused credential flows in e2e tests and examples by jzaffiro · Pull Request #27508 · microsoft/FluidFramework

jzaffiro · 2026-06-08T17:29:08Z

Now that the new credential format has been implemented (#26714) and tested, remove the old formats from both the real service tests and the Fluid examples.

AB#74331

Copilot

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

github-actions · 2026-06-08T17:30:47Z

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (712 lines, 14 files), I've queued these reviewers:

Correctness — logic errors, race conditions, lifecycle issues
Security — vulnerabilities, secret exposure, injection
API Compatibility — breaking changes, release tags, type design
Performance — algorithmic regressions, memory leaks
Testing — coverage gaps, hollow tests

How this works

Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.
Tick Start review below to dispatch the review fleet.
After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.
This comment updates as new commits land; your reviewer selections are preserved.
Start review

Abe27342 · 2026-06-08T20:32:14Z

-			username,
-			password,
-		};
-		return fetchTokens(server, scope, clientConfig, credentials);


is fetchTokens used still? (fine if so, but check please :))

No longer used - that and its caller (refreshTokens) have been removed.

alexvy86

The changes to examples/ concern me a bit... without understanding them 100%, it seems like things are changing such that only Microsoft devs would be able to run examples targeting odsp? (Because running tenant-setup requires interaction with internal Microsoft systems). cc @ChumpChief for thoughts on that part since he refactored things recently-ish in that space.

alexvy86 · 2026-06-12T15:58:10Z

+		_server: string,
+		_clientConfig: IPublicClientConfig,


These two aren't used at all anymore, right? Should they just be removed?

jzaffiro · 2026-06-12T17:27:00Z

The changes to examples/ concern me a bit... without understanding them 100%, it seems like things are changing such that only Microsoft devs would be able to run examples targeting odsp? (Because running tenant-setup requires interaction with internal Microsoft systems). cc @ChumpChief for thoughts on that part since he refactored things recently-ish in that space.

I don't think this is much different than requiring a script to get an old tenant to target ODSP, which was the case before. Please correct me if I'm wrong though.

ChumpChief · 2026-06-12T17:34:15Z

The changes to examples/ concern me a bit... without understanding them 100%, it seems like things are changing such that only Microsoft devs would be able to run examples targeting odsp? (Because running tenant-setup requires interaction with internal Microsoft systems). cc @ChumpChief for thoughts on that part since he refactored things recently-ish in that space.

I don't think this is much different than requiring a script to get an old tenant to target ODSP, which was the case before. Please correct me if I'm wrong though.

That side of things is probably fine, afaict this is mostly just trading one MSFT-only approach for another as you say. However please make sure the errors and documentation are sufficient for MSFT devs to figure this out - based on my read here, I don't know where the appropriate package is or how to set it up.

ChumpChief · 2026-06-12T17:22:46Z

+	const packageImportLocation = process.env.token__package__import__location;
+	if (packageImportLocation === undefined) {
+		throw new Error(
+			'The FIC credential flow relies on a test tenant checkout client, but no client was found. Ensure that the environment variable "token__package__import__location" is set to the location of a package that exports a compatible client.',


This error and the other errors below are hard to understand to the average user who is not immersed in FIC world :)

Recommend only giving directives that a customer who hits this will know how to do (e.g. "run this command" or "see this documentation page on what to do").

Also nit that we use double-quotes.

Suggested change

'The FIC credential flow relies on a test tenant checkout client, but no client was found. Ensure that the environment variable "token__package__import__location" is set to the location of a package that exports a compatible client.',

"The FIC credential flow relies on a test tenant checkout client, but no client was found. Run my really cool command to provide it",

ChumpChief · 2026-06-12T17:27:49Z

+	return usernames.map((username) => ficLoginCredentials(username, odspEndpointName));
+}
+
+const ficLoginCredentials = (


Nit, prefer a verb name

Suggested change

const ficLoginCredentials = (

const getFicLoginCredentials = (

jzaffiro · 2026-06-12T18:49:10Z

-The following environment variables must be set:
+If you're a Microsoft developer, use the `@ff-internal/tenant-setup` package to populate this variable for `start:spo`:

-   local\_\_testing\_\_clientId


@ChumpChief @alexvy86 is getkeys still in use? I'm pretty sure it's not and that the test tenant variables have been removed from the key vault but I'm not positive. If this is still a valid use case I'll revert this change.

github-actions · 2026-06-12T19:03:20Z

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  290922 links
    1934 destination URLs
    2184 URLs ignored
       0 warnings
       0 errors

jzaffiro added 3 commits June 1, 2026 21:56

WIP: clean up unused credential management flows

313ee5d

Fix formatting

a58469a

Update examples to parse token credentials

70a2c1e

Copilot AI review requested due to automatic review settings June 8, 2026 17:29

Copilot started reviewing on behalf of jzaffiro June 8, 2026 17:29 View session

Copilot AI reviewed Jun 8, 2026

View reviewed changes

Update script name in pipeline

8b0b9e7

Abe27342 reviewed Jun 8, 2026

View reviewed changes

jzaffiro added 3 commits June 11, 2026 17:33

WIP: Remove refresh token flow

352e9e5

Use pipeline host test branch for staging the changes

9769dd1

Use package staging branch in stress pipeline

d5d9ac3

alexvy86 reviewed Jun 12, 2026

View reviewed changes

Remove unused params

f329083

ChumpChief reviewed Jun 12, 2026

View reviewed changes

Address PR feedback

eb7453d

jzaffiro commented Jun 12, 2026

View reviewed changes

Update error messages with better instructions

5581368

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove unused credential flows in e2e tests and examples#27508

Remove unused credential flows in e2e tests and examples#27508
jzaffiro wants to merge 10 commits into
mainfrom
test/jzaffiro/simplifyTenantSetup

jzaffiro commented Jun 8, 2026 •

edited by azure-boards Bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented Jun 8, 2026 •

edited

Loading

Uh oh!

Abe27342 Jun 8, 2026

Uh oh!

jzaffiro Jun 11, 2026

Uh oh!

alexvy86 left a comment

Uh oh!

alexvy86 Jun 12, 2026

Uh oh!

jzaffiro commented Jun 12, 2026

Uh oh!

ChumpChief commented Jun 12, 2026 •

edited

Loading

Uh oh!

ChumpChief Jun 12, 2026

Uh oh!

ChumpChief Jun 12, 2026

Uh oh!

jzaffiro Jun 12, 2026

Uh oh!

github-actions Bot commented Jun 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	'The FIC credential flow relies on a test tenant checkout client, but no client was found. Ensure that the environment variable "token__package__import__location" is set to the location of a package that exports a compatible client.',
	"The FIC credential flow relies on a test tenant checkout client, but no client was found. Run my really cool command to provide it",

	const ficLoginCredentials = (
	const getFicLoginCredentials = (

Conversation

jzaffiro commented Jun 8, 2026 • edited by azure-boards Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Abe27342 Jun 8, 2026

Choose a reason for hiding this comment

Uh oh!

jzaffiro Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

alexvy86 left a comment

Choose a reason for hiding this comment

Uh oh!

alexvy86 Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

jzaffiro commented Jun 12, 2026

Uh oh!

ChumpChief commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChumpChief Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

ChumpChief Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

jzaffiro Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 12, 2026

linkcheck output

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jzaffiro commented Jun 8, 2026 •

edited by azure-boards Bot

Loading

github-actions Bot commented Jun 8, 2026 •

edited

Loading

ChumpChief commented Jun 12, 2026 •

edited

Loading