Skip to content

Change cp command to use -rfL option#335

Merged
Amronos merged 1 commit into
micro-ROS:rollingfrom
Caedael:rolling
May 13, 2026
Merged

Change cp command to use -rfL option#335
Amronos merged 1 commit into
micro-ROS:rollingfrom
Caedael:rolling

Conversation

@Caedael

@Caedael Caedael commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

resolve symlinks from extra_packages folder

#320
(changed branch to rolling)

@Caedael
Change cp command to use -rfL option
296a796 
resolve symlinks from extra_packages folder
@Caedael Caedael mentioned this pull request Apr 30, 2026
Closed
Amronos
Amronos approved these changes Apr 30, 2026
View reviewed changes

@Amronos Amronos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The CI failures are unrelated to this PR and will be fixed with #323.

@Amronos Amronos requested a review from Narukara April 30, 2026 14:13
@Narukara

Narukara commented May 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

May I ask — did you actually encounter a problem that required cp -rfL to fix? 🤔

@Caedael

Caedael commented May 11, 2026

Copy link
Copy Markdown
Contributor Author

May I ask — did you actually encounter a problem that required cp -rfL to fix? 🤔

When i work with custom messages, i don't wanted to copy them manually every time after a change from my workspace to the extra packages folder.

@Narukara

Narukara commented May 12, 2026

Copy link
Copy Markdown
Contributor

When i work with custom messages, i don't wanted to copy them manually every time after a change from my workspace to the extra packages folder.

I'm sorry, but I didn't understand what you meant. Could you please explain in more detail?

@Amronos, do you have any thoughts on this?

@Amronos

Amronos commented May 12, 2026

Copy link
Copy Markdown
Member

From what I understand, -L properly copies the directories that the symlinks point to.
It is needed as some people may symlink their own packages into the extra_packages directory to iterate faster on those packages.

@Narukara

Narukara commented May 13, 2026

Copy link
Copy Markdown
Contributor

From what I understand, -L properly copies the directories that the symlinks point to. It is needed as some people may symlink their own packages into the extra_packages directory to iterate faster on those packages.

Oh, I forgot that symbolic links can point to entire directories. Thanks for the clarification!

@Amronos Amronos merged commit 2f73852 into micro-ROS:rolling May 13, 2026
2 of 7 checks passed
This was referenced May 13, 2026
Merged
Merged
Merged
Amronos pushed a commit that referenced this pull request May 13, 2026
@mergify @Caedael
Change cp command to use -rfL option (backport #335) (#339)
f5a7959 
Resolve symlinks from the `extra_packages` directory

(cherry picked from commit 2f73852)

Co-authored-by: Adrian <[email protected]>
Amronos pushed a commit that referenced this pull request May 13, 2026
@mergify @Caedael
Change cp command to use -rfL option (backport #335) (#338)
160b103 
Resolve symlinks from the `extra_packages` directory

(cherry picked from commit 2f73852)

Co-authored-by: Adrian <[email protected]>
Amronos added a commit that referenced this pull request May 13, 2026
@mergify @Caedael @Amronos
Change cp command to use -rfL option (backport #335) (#337)
c706796 
Resolve symlinks from the `extra_packages` directory

(cherry picked from commit 2f73852)

Co-authored-by: Adrian <[email protected]>
Co-authored-by: Aarav Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Narukara Narukara Narukara approved these changes
@Amronos Amronos Amronos approved these changes

Assignees

No one assigned

Labels

backport-humble backport-jazzy backport-kilted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Caedael @Narukara @Amronos