Implement notification actions and categories for timer events

[mookwoo]

This pull request adds actionable notifications to the timer application, allowing users to interact directly with timer notifications (e.g., restart, add time, stop) and improves how notifications are handled and routed to the correct timer window. The main changes include registering notification categories, handling notification actions, associating notifications with specific timer controllers, and adding new timer control methods.

Notification actions and handling:

• Registered a notification category with three actions ("Restart", "+5 min", "Stop") for timer completion notifications, enabling actionable notifications in the app (registerNotificationCategories in AppDelegate.swift). [1] [2]
• Implemented a handler for notification actions that routes the selected action to the appropriate timer controller based on a unique identifier in the notification payload (userNotificationCenter(_:didReceive:withCompletionHandler:) and handleNotificationAction in AppDelegate.swift). [1] [2]

Timer controller enhancements:

• Added a unique identifier property to each MVTimerController instance to associate notifications with specific timer windows.
• Modified timer completion notifications to include the controller identifier and category, enabling precise action routing.

Timer control methods:

• Added new methods to MVTimerController for restarting the last timer, adding five minutes, and resetting the timer, supporting the new notification actions.

Identifiers centralization:

• Introduced a new MVNotificationIdentifiers enum to centralize all notification-related string constants.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds actionable “timer complete” notifications and routes notification actions back to the correct MVTimerController instance.

Changes:

• Introduces notification category/action identifiers and a userInfo key for controller routing.
• Attaches notification category + controller identifier to timer-complete notifications.
• Implements UNNotificationCenter action handling to restart/add time/stop/open the corresponding timer window.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
Timer/MVUserDefaultsKeys.swift	Adds shared notification identifier constants used across controller + AppDelegate.
Timer/MVTimerController.swift	Adds per-controller UUID and new timer action helpers; enriches notification payload with category + routing info.
Timer/AppDelegate.swift	Registers notification categories and handles notification actions by delegating to the correct controller.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

[mookwoo]

Addressed the remaining Copilot review comments:

• Split the notification userInfo key into MVNotificationUserInfoKeys so it is no longer grouped with notification category/action identifiers.
• Reworked notification response handling to dispatch onto the main queue, perform the timer action, then call the completion handler afterward.
• Applied the current staysOnTop window level when creating a fallback timer controller.
• Aligned the notification “Stop” action with the existing stop command behavior.

Verified with make test.

[mookwoo]

Hi! Just wanted to follow up on this PR, it's been about a month since I submitted it. Would love to get any feedback or know if there's anything I can update to help move it forward. Thanks! 🙏

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

Timer/MVTimerController.swift:83

• UNUserNotificationCenter.add(_:) is called without a completion handler, so failures to schedule the notification (e.g., authorization denied, delivery errors) will be silently ignored. Logging the error will make notification/action issues diagnosable in the field.

    let request = UNNotificationRequest(identifier: UUID().uuidString, content: content, trigger: nil)
    UNUserNotificationCenter.current().add(request)