Skip to content

Update aiohttp to ~=3.13.0 and bump test deps#266

Open
miaucl wants to merge 1 commit into
mainfrom
update-deps-aiohttp-3.13
Open

Update aiohttp to ~=3.13.0 and bump test deps#266
miaucl wants to merge 1 commit into
mainfrom
update-deps-aiohttp-3.13

Conversation

@miaucl

@miaucl miaucl commented Jun 3, 2026

Copy link
Copy Markdown
Owner

Summary

Update dependency pins to ensure compatibility between aiohttp 3.13.x and aioresponses 0.7.8.

Changes

  • Pin aiohttp~=3.13.0 in pyproject.toml, requirements.txt, and requirements_dev.txt
  • Bump pytest-asyncio minimum to >=1.4.0 in requirements_test.txt
  • Ensures aioresponses (which is not yet compatible with newer aiohttp versions) works correctly

Testing

All 135 unit tests pass locally with these dependency versions.

- Pin aiohttp~=3.13.0 in pyproject.toml, requirements.txt, and requirements_dev.txt
- Bump pytest-asyncio minimum to >=1.4.0
- Ensures compatibility with aioresponses>=0.7.8

Co-authored-by: Copilot <[email protected]>
@miaucl miaucl requested a review from tr4nt0r as a code owner June 3, 2026 11:39
@github-actions github-actions Bot added the ♻️ dependencies Pull requests that update a dependency file label Jun 3, 2026
@codecov

codecov Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.51%. Comparing base (a52907d) to head (a952247).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #266   +/-   ##
=======================================
  Coverage   92.51%   92.51%           
=======================================
  Files           6        6           
  Lines         708      708           
  Branches       30       30           
=======================================
  Hits          655      655           
  Misses         46       46           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@miaucl

miaucl commented Jun 3, 2026

Copy link
Copy Markdown
Owner Author

aioresponses 0.7.8 is not compatible with aiohttp 3.14.0, so we pin it to the minor for now.

--> #265

@miaucl miaucl self-assigned this Jun 3, 2026
@miaucl miaucl enabled auto-merge (squash) June 3, 2026 11:42
@tr4nt0r

tr4nt0r commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

We should only pin in in requirements_dev.txt, to run the test suite, not for the package itself. Long-term maybe we should rewrite the tests and get rid of aioresponses

@miaucl

miaucl commented Jun 3, 2026

Copy link
Copy Markdown
Owner Author

Unit tests do not use the _dev file imo?

@tr4nt0r

tr4nt0r commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Oh, you are right, deps are installed with requirements.txt and requirements_test.txt

      - name: Install dependencies
        run: |
            python -m pip install --upgrade pip
            pip install -r requirements.txt
            pip install -r requirements_test.txt

Comment thread pyproject.toml
]
dependencies = [
"aiohttp>=3.10",
"aiohttp~=3.13.0",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"aiohttp~=3.13.0",
"aiohttp>=3.13.0",

Comment thread requirements_test.txt
@@ -1,5 +1,5 @@
aioresponses>=0.7.8
pytest-asyncio>=1.3.0
pytest-asyncio>=1.4.0

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be bumped by dependabot

Suggested change
pytest-asyncio>=1.4.0
pytest-asyncio>=1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

♻️ dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants