4146 date picker disabled with value styling#4554
Conversation
|
View your canary branch deployment here: https://mi6.github.io/ic-ui-kit/branches/4146-date-picker-disabled-with-value-styling/canary-web-components |
|
Cypress visual tests failed. |
64b0ec4 to
ee0f4ee
Compare
GCHQ-Developer-299
left a comment
There was a problem hiding this comment.
Checked it out in Storybook, looks good to me :)
note: in the Playground storybook I entered a value and then toggled disabled to true and the styling didn't immediately apply, but when i refreshed the storybook it applied correctly. Because your cypress test shows the styling applying correctly also, i'm happy to approve
…or disabled date picker Update styling of text and clear button for disabled date picker when there's already a value . #4146
ee0f4ee to
e83f89a
Compare
Summary of the changes
Update styling of text and clear button for disabled date picker when there's already a value.
Test disabled with value styling for date picker.
Related issue
#4146
Checklist
General
Testing
Accessibility
Resize/zoom behaviour
System modes
Testing content extremes