Skip to content

4146 date picker disabled with value styling#4554

Merged
GCHQ-Developer-530 merged 2 commits into
developfrom
4146-date-picker-disabled-with-value-styling
Jul 3, 2026
Merged

4146 date picker disabled with value styling#4554
GCHQ-Developer-530 merged 2 commits into
developfrom
4146-date-picker-disabled-with-value-styling

Conversation

@GCHQ-Developer-530

@GCHQ-Developer-530 GCHQ-Developer-530 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Summary of the changes

Update styling of text and clear button for disabled date picker when there's already a value.
Test disabled with value styling for date picker.

Related issue

#4146

Checklist

General

  • Changes to docs package checked and committed.
  • All acceptance criteria reviewed and met.

Testing

  • Relevant unit tests and visual regression tests added.
  • Visual testing against Figma component specification completed.
  • Playground stories in React Storybook up to date, with any prop changes and additions addressed.
  • Compare performance of modified components against develop using Performance addon in React Storybook.

Accessibility

  • Accessibility Insights FastPass performed.
  • A11y unit test added and yields no issues.
  • A11y plug-in on Storybook yields no issues.
  • Manual screen reader testing performed using NVDA and VoiceOver.
  • Manual keyboard testing for keyboard controls and logical focus order.
  • Correct roles used and ARIA attributes used correctly where required.
  • Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

Resize/zoom behaviour

  • Page can be zoomed to 400% with no loss of content.
  • Screen magnifier used with no issues.
  • Text resized to 200% with no loss of content.
  • Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.

System modes

  • Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
  • Windows High Contrast mode tested with no loss of content.
  • System light and dark mode tested with no loss of content.
  • Browser support tested (Chrome, Safari, Firefox and Edge).

Testing content extremes

  • Min/max content examples tested with no loss of content or overflow.
  • All prop combinations work without issue.
  • Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
  • Controlled and uncontrolled input components tested.
  • Props/slots can be updated after initial render.

@github-actions

Copy link
Copy Markdown
Contributor

@GCHQ-Developer-530
GCHQ-Developer-530 force-pushed the 4146-date-picker-disabled-with-value-styling branch from 64b0ec4 to ee0f4ee Compare June 29, 2026 08:51

@GCHQ-Developer-299 GCHQ-Developer-299 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked it out in Storybook, looks good to me :)

Image

note: in the Playground storybook I entered a value and then toggled disabled to true and the styling didn't immediately apply, but when i refreshed the storybook it applied correctly. Because your cypress test shows the styling applying correctly also, i'm happy to approve

…or disabled date picker

Update styling of text and clear button for disabled date picker when there's already a value

. #4146
@GCHQ-Developer-530
GCHQ-Developer-530 merged commit aad6792 into develop Jul 3, 2026
6 checks passed
@GCHQ-Developer-530
GCHQ-Developer-530 deleted the 4146-date-picker-disabled-with-value-styling branch July 3, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants