Skip to content

[#3857]: Upgrade stencil#4549

Closed
oakenroot wants to merge 10 commits into
mi6:developfrom
oakenroot:chore/3857-upgrade-stencil
Closed

[#3857]: Upgrade stencil#4549
oakenroot wants to merge 10 commits into
mi6:developfrom
oakenroot:chore/3857-upgrade-stencil

Conversation

@oakenroot

@oakenroot oakenroot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary of the changes

Second of a few dependency PRs, with the end goal of reducing advisories and usage of deprecated packages. This makes three commits:

  1. Upgrade @stencil/core
  2. Update various auto-generated files
  3. Make a one-line fix that couldn't be done automatically

So while the diff is large here, there's not actually much going on/this would be easy to replicate locally

Related issue

#3857

Checklist

General

  • Changes to docs package checked and committed.
  • All acceptance criteria reviewed and met.

Testing

  • Relevant unit tests and visual regression tests added.
  • Visual testing against Figma component specification completed.
  • Playground stories in React Storybook up to date, with any prop changes and additions addressed.
  • Compare performance of modified components against develop using Performance addon in React Storybook.

Accessibility

  • Accessibility Insights FastPass performed.
  • A11y unit test added and yields no issues.
  • A11y plug-in on Storybook yields no issues.
  • Manual screen reader testing performed using NVDA and VoiceOver.
  • Manual keyboard testing for keyboard controls and logical focus order.
  • Correct roles used and ARIA attributes used correctly where required.
  • Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

Resize/zoom behaviour

  • Page can be zoomed to 400% with no loss of content.
  • Screen magnifier used with no issues.
  • Text resized to 200% with no loss of content.
  • Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.

System modes

  • Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
  • Windows High Contrast mode tested with no loss of content.
  • System light and dark mode tested with no loss of content.
  • Browser support tested (Chrome, Safari, Firefox and Edge).

Testing content extremes

  • Min/max content examples tested with no loss of content or overflow.
  • All prop combinations work without issue.
  • Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
  • Controlled and uncontrolled input components tested.
  • Props/slots can be updated after initial render.

@oakenroot
oakenroot force-pushed the chore/3857-upgrade-stencil branch 2 times, most recently from 990601f to c4212da Compare June 25, 2026 13:13
@oakenroot

Copy link
Copy Markdown
Contributor Author

There's one test here that failed in CI which I can't replicate locally, not sure what's going on... (in packages/react/src/component-tests/IcSideNavigation/IcSideNavigation.cy.tsx)

Would be helpful if one of the actual devs could lend a hand and give a quick look!

@GCHQ-Developer-530

Copy link
Copy Markdown
Contributor

There's one test here that failed in CI which I can't replicate locally, not sure what's going on... (in packages/react/src/component-tests/IcSideNavigation/IcSideNavigation.cy.tsx)

Would be helpful if one of the actual devs could lend a hand and give a quick look!

Hi @oakenroot, we were also having this issue when trying to upgrade Stencil. They seem to be flaky tests but after quite a bit of investigation we couldn't find a way to get them to run consistently, hence us parking the ticket for a little while to work on some higher priority work within the team. Something we did consider was moving from Electron to Chrome to run the Cypress tests, but we didn't get around to implementing it.

@GCHQ-Developer-112
GCHQ-Developer-112 force-pushed the develop branch 2 times, most recently from bc8e8f9 to a01c50b Compare July 3, 2026 14:11
@oakenroot
oakenroot force-pushed the chore/3857-upgrade-stencil branch from c4212da to a3c006b Compare July 8, 2026 22:27
oakenroot added 2 commits July 9, 2026 00:25
Electron has been producing inconsistent visual regression results and
flaky timeouts. Chrome is already installed in CI but was never used
for component tests. Also fixes pre-existing ESLint errors in the
cypress config (unused fs import, outdated eslint-disable rule).
@oakenroot
oakenroot force-pushed the chore/3857-upgrade-stencil branch from 5185e24 to 7052b54 Compare July 8, 2026 23:58
@oakenroot

Copy link
Copy Markdown
Contributor Author

Closing for now, will work on this on my fork where I can run tests in CI more freely. Will reopen when things are passing.

@oakenroot oakenroot closed this Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants