[#3857]: Upgrade stencil#4549
Conversation
990601f to
c4212da
Compare
|
There's one test here that failed in CI which I can't replicate locally, not sure what's going on... (in Would be helpful if one of the actual devs could lend a hand and give a quick look! |
Hi @oakenroot, we were also having this issue when trying to upgrade Stencil. They seem to be flaky tests but after quite a bit of investigation we couldn't find a way to get them to run consistently, hence us parking the ticket for a little while to work on some higher priority work within the team. Something we did consider was moving from Electron to Chrome to run the Cypress tests, but we didn't get around to implementing it. |
bc8e8f9 to
a01c50b
Compare
- Fix TS2339 errors: split clickOnShadowEl().wait() into separate statements since clickOnShadowEl returns void - Bump visual regression thresholds for multi-level navigation snapshots from 0 to 0.02 to accommodate Stencil upgrade rendering differences
c4212da to
a3c006b
Compare
Electron has been producing inconsistent visual regression results and flaky timeouts. Chrome is already installed in CI but was never used for component tests. Also fixes pre-existing ESLint errors in the cypress config (unused fs import, outdated eslint-disable rule).
5185e24 to
7052b54
Compare
|
Closing for now, will work on this on my fork where I can run tests in CI more freely. Will reopen when things are passing. |
Summary of the changes
Second of a few dependency PRs, with the end goal of reducing advisories and usage of deprecated packages. This makes three commits:
@stencil/coreSo while the diff is large here, there's not actually much going on/this would be easy to replicate locally
Related issue
#3857
Checklist
General
Testing
Accessibility
Resize/zoom behaviour
System modes
Testing content extremes