[#4193]: upgrade typescript#4547
Conversation
|
I now have follow up branches to this to solve #3857 and #4205, which both seem to be working nicely locally. Have pushed these to my fork, eg https://github.com/oakenroot/ic-ui-kit/tree/chore/4205-upgrade-lerna. I can PR these in sequence once this merges, but can't stack as I can't create branches directly on this repo. There are more likely more dependency/audit bits to do after bumping lerna, but will leave for now in case major changes are needed to any of this. |
|
Ok, as it turns out I've had a go at removing vulns, and have managed to get down to 2 advisories. Not run much manual testing but all validation and unit testing is passing locally... |
|
Hi @oakenroot, I don't seem to get those docs changes if I build locally, not sure on other members of the team. Please could you drop the commit from this PR anyway and then it can be looked into in a separate PR as you suggested? |
|
heya @oakenroot, thank you for another contribution :) unfortunately due to our commitlint setup, you'll need to separate the changes to each package into separate commits (e.g. /canary-react changes into a |
948634a to
9230742
Compare
9230742 to
0ef8164
Compare
|
Alright, have dropped the docs commit and split up the version bumps, should be good now... :) |
Summary of the changes
Upgrades typescript to 5.8 across the board, which is a blocker on #4205. I have gone for 5.8 here, but can go for 5.2 if that's preferable. 5.8 is the highest we can go right now, because 5.9 introduces
autocorrect: booleanonHTMLElementwhich conflicts with ours, which doautocorrect: "on" | "off".This also makes changes to docs, which popped up when running
npm run buildto check everything is happy. I assume these should have been updated in previous PRs. Happy to drop the commit from here and put on a separate PR if people like.Related issue
#4193
Checklist
General
Testing
Accessibility
Resize/zoom behaviour
System modes
Testing content extremes