fix: include filename in UnicodeDecodeError during vault gather (#32)#60
Open
MohammadYusif wants to merge 1 commit into
Open
fix: include filename in UnicodeDecodeError during vault gather (#32)#60MohammadYusif wants to merge 1 commit into
MohammadYusif wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UnicodeDecodeErrorfromf.read()in_get_md_front_matter_and_contentwas being swallowed by the trailing bareexcept:, which then tried toreturn {}, file_stringwherefile_stringwas never assigned — so the user actually saw a confusingUnboundLocalErrorinstead of the real decode error.UnicodeDecodeErrorexplicitly and re-raises it with the offending filepath appended to the message, so the failing file is immediately identifiable.Changes
obsidiantools/md_utils.py: in_get_md_front_matter_and_content, added an explicitexcept UnicodeDecodeError(before the catch-all) that re-raises aUnicodeDecodeErrorwith(in file: <filepath>)appended to the reason. Placed ahead of the bareexcept:so the decode error is no longer swallowed.tests/test_md_utils.py: addedtest_non_utf8_file_error_includes_filepath, which writes a temp file with an invalid0xffbyte, calls the publicget_front_matter, and asserts the raisedUnicodeDecodeErrormessage contains the filepath. Verified this test fails on the unpatched code (it raisedUnboundLocalError) and passes with the fix.Fixes #32