Skip to content

[chore]: comment out unused ReactPlayer import#308

Merged
leecalcote merged 1 commit into
meshery:masterfrom
banana-three-join:chore/banana-three-join/commentout-react-player
Jul 20, 2026
Merged

[chore]: comment out unused ReactPlayer import#308
leecalcote merged 1 commit into
meshery:masterfrom
banana-three-join:chore/banana-three-join/commentout-react-player

Conversation

@banana-three-join

Copy link
Copy Markdown
Contributor

Notes for Reviewers

Netlify build failures were happening with the following error:

2:22:56 PM: Failed to compile.
2:22:56 PM: 
2:22:56 PM: [eslint]
2:22:56 PM: src/App.js
2:22:56 PM:   Line 7:8:  'ReactPlayer' is defined but never used  no-unused-vars
2:22:56 PM: ​
2:22:56 PM: "build.command" failed

ReactPlayer was being imported but not being utilized so it was causing an ESLint error.

Signed commits

  • Yes, I signed my commits.

@welcome

welcome Bot commented Jul 20, 2026

Copy link
Copy Markdown

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while performing a commit.

@netlify

netlify Bot commented Jul 20, 2026

Copy link
Copy Markdown

Deploy Preview for meshery-play ready!

Name Link
🔨 Latest commit 5691717
🔍 Latest deploy log https://app.netlify.com/projects/meshery-play/deploys/6a5eab6862363e000951b26c
😎 Deploy Preview https://deploy-preview-308--meshery-play.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@leecalcote
leecalcote merged commit 98bf2dc into meshery:master Jul 20, 2026
2 of 3 checks passed
@welcome

welcome Bot commented Jul 20, 2026

Copy link
Copy Markdown

Thanks for your contribution to Meshery! 🎉

Meshery Logo
        Join the community, if you haven't yet and please leave a ⭐ star on the project. 😄

@github-actions

Copy link
Copy Markdown
PR Preview Action v1.6.3
Preview removed because the pull request was closed.
2026-07-20 23:19 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants