Feature/orders cho pro#123
Merged
Merged
Conversation
Promote the Orders Checkout Pro feature from beta to stable by bumping the version from 3.3.0-beta.1 to 3.3.0 and updating the release date in the changelog from 2026-06-23 to 2026-06-30. Fix two pylint violations in FakeHttpClient (test_order_checkout_pro): - R0913/R0917: too many (positional) arguments on post() and get() — collapsed optional params into **kwargs so the signature stays under the 5-argument limit while preserving all recorded call fields. Fix integration test regression in test_plan: - The update call was sending the full API response object back, which included read-only fields (id, date_created, summarized, etc.) that the API rejects with 400 "Parameters passed are invalid". Replace it with an explicit update_payload containing only the writable fields (reason, auto_recurring, back_url). Co-Authored-By: Claude Sonnet 4.6 (1M context) <[email protected]>
Raise max-args and max-positional-arguments to 7 in setup.cfg so the pylint DESIGN rules match the actual method signatures in HttpClient and its test doubles, instead of suppressing warnings per-line. Restore explicit signatures on FakeHttpClient.post() and .get() in test_order_checkout_pro — the previous **kwargs workaround silenced R0913/R0917 but introduced W0221 (arguments-differ) because the override no longer matched the base class contract. Co-Authored-By: Claude Sonnet 4.6 (1M context) <[email protected]>
Add max-args = 7 and max-positional-arguments = 7 to tests/.pylintrc so the limits are consistent with setup.cfg. The tests/.pylintrc takes precedence over the root config when pylint runs against the tests directory, so the DESIGN section was missing and R0913/R0917 were still triggered on FakeHttpClient methods. Co-Authored-By: Claude Sonnet 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.