Skip to content

fix(executor): correct cmux review-surface attach in /launch (v1.3.2)#7

Merged
memorysaver merged 2 commits into
mainfrom
fix/cmux-launch-surface
Jun 5, 2026
Merged

fix(executor): correct cmux review-surface attach in /launch (v1.3.2)#7
memorysaver merged 2 commits into
mainfrom
fix/cmux-launch-surface

Conversation

@memorysaver

Copy link
Copy Markdown
Owner

Fixes how aep-launch / aep-executor attach a cmux review surface. Three bugs, reported and verified live from a downstream (looplia) session.

Bugs fixed

  1. Detection gated on $CMUX_SOCKET → a host where the cmux CLI is reachable but $CMUX_SOCKET is unset (Claude Code inside a cmux-managed tmux session) wrongly fell back to headless B2. Detection now keys on cmux CLI reachable AND a target pane resolves (cmux tree ◀ here / $CMUX_PANE_ID), independent of $CMUX_SOCKET.
  2. Wrong tab placement → the bare cmux new-surface defaulted to an unset $CMUX_WORKSPACE_ID. Now /launch resolves the orchestrator's own pane from cmux tree and opens a sibling tab via new-surface --workspace <ws> --pane <pane> --focus true. cmux new-workspace (separate top-level workspace) is kept out of the launch path.
  3. Bootstrap lost → an attached cmux surface focuses the tmux composer and blocks external send-keys, so the bootstrap couldn't land. Reordered: spawn tmux → wait ready → send bootstrap via tmux send-keysthen attach the cmux tab.

Files

  • skills/agentic-development-workflow/launch/SKILL.md — Spawn (defer cmux), Send Bootstrap (always tmux), new "Attach the cmux Review Tab (B1)" step
  • skills/patterns/executor/references/backends.md — detection, B1 recipe, present(), fallback ladder
  • skills/patterns/executor/SKILL.md — detection summary
  • marketplace.json 1.3.1 → 1.3.2 + CHANGELOG.md [1.3.2]

Acceptance

  • cmux running but $CMUX_SOCKET unset → review tab opens in the orchestrator's current cmux project pane (beside its own tab), not a new top-level workspace and not silent headless tmux.
  • The build agent receives its bootstrap (sent before the surface attached).
  • No cmux new-workspace in the launch path.

Note: the cmux verbs were verified live in the reporting session; the integration here should be confirmed on an actual cmux host before relying on it.

🤖 Generated with Claude Code

memorysaver and others added 2 commits June 5, 2026 17:11
Three bugs in how aep-launch / aep-executor attach a cmux review tab, reported
and verified live from a downstream (looplia) session:

1. Detection gated cmux on $CMUX_SOCKET, so a host where the cmux CLI is reachable
   but $CMUX_SOCKET is unset (Claude Code inside a cmux-managed tmux session)
   wrongly fell back to headless B2. Detection now keys on "cmux CLI reachable AND
   a target pane resolves" (cmux tree '<here>' marker / $CMUX_PANE_ID).
2. The tab was created with a bare `cmux new-surface` (defaults to an unset
   $CMUX_WORKSPACE_ID) -> now it resolves the orchestrator's own pane from
   `cmux tree` and opens a SIBLING tab via
   `new-surface --workspace <ws> --pane <pane> --focus true`. `new-workspace`
   (separate top-level workspace) is kept out of the launch path.
3. The surface attached BEFORE the bootstrap was sent; an attached cmux surface
   focuses the tmux composer and blocks external send-keys, so the bootstrap
   couldn't land. Reordered: spawn tmux -> wait ready -> send bootstrap via tmux
   send-keys -> THEN attach the cmux tab.

Files: launch/SKILL.md (Spawn + Send Bootstrap + new "Attach the cmux Review Tab"
step), executor/references/backends.md (detection, B1 recipe, present(), fallback
ladder), executor/SKILL.md (detection summary).

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
marketplace.json 1.3.1 -> 1.3.2 + CHANGELOG [1.3.2].

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
@memorysaver memorysaver merged commit 1f7d452 into main Jun 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant