fix(executor): correct cmux review-surface attach in /launch (v1.3.2)#7
Merged
Conversation
Three bugs in how aep-launch / aep-executor attach a cmux review tab, reported and verified live from a downstream (looplia) session: 1. Detection gated cmux on $CMUX_SOCKET, so a host where the cmux CLI is reachable but $CMUX_SOCKET is unset (Claude Code inside a cmux-managed tmux session) wrongly fell back to headless B2. Detection now keys on "cmux CLI reachable AND a target pane resolves" (cmux tree '<here>' marker / $CMUX_PANE_ID). 2. The tab was created with a bare `cmux new-surface` (defaults to an unset $CMUX_WORKSPACE_ID) -> now it resolves the orchestrator's own pane from `cmux tree` and opens a SIBLING tab via `new-surface --workspace <ws> --pane <pane> --focus true`. `new-workspace` (separate top-level workspace) is kept out of the launch path. 3. The surface attached BEFORE the bootstrap was sent; an attached cmux surface focuses the tmux composer and blocks external send-keys, so the bootstrap couldn't land. Reordered: spawn tmux -> wait ready -> send bootstrap via tmux send-keys -> THEN attach the cmux tab. Files: launch/SKILL.md (Spawn + Send Bootstrap + new "Attach the cmux Review Tab" step), executor/references/backends.md (detection, B1 recipe, present(), fallback ladder), executor/SKILL.md (detection summary). Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
marketplace.json 1.3.1 -> 1.3.2 + CHANGELOG [1.3.2]. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes how
aep-launch/aep-executorattach a cmux review surface. Three bugs, reported and verified live from a downstream (looplia) session.Bugs fixed
$CMUX_SOCKET→ a host where thecmuxCLI is reachable but$CMUX_SOCKETis unset (Claude Code inside a cmux-managed tmux session) wrongly fell back to headless B2. Detection now keys on cmux CLI reachable AND a target pane resolves (cmux tree◀ here/$CMUX_PANE_ID), independent of$CMUX_SOCKET.cmux new-surfacedefaulted to an unset$CMUX_WORKSPACE_ID. Now/launchresolves the orchestrator's own pane fromcmux treeand opens a sibling tab vianew-surface --workspace <ws> --pane <pane> --focus true.cmux new-workspace(separate top-level workspace) is kept out of the launch path.send-keys, so the bootstrap couldn't land. Reordered: spawn tmux → wait ready → send bootstrap viatmux send-keys→ then attach the cmux tab.Files
skills/agentic-development-workflow/launch/SKILL.md— Spawn (defer cmux), Send Bootstrap (always tmux), new "Attach the cmux Review Tab (B1)" stepskills/patterns/executor/references/backends.md— detection, B1 recipe,present(), fallback ladderskills/patterns/executor/SKILL.md— detection summarymarketplace.json1.3.1 → 1.3.2 +CHANGELOG.md[1.3.2]Acceptance
$CMUX_SOCKETunset → review tab opens in the orchestrator's current cmux project pane (beside its own tab), not a new top-level workspace and not silent headless tmux.cmux new-workspacein the launch path.🤖 Generated with Claude Code