Skip to content

Custom player error screen#234

Open
hfellerhoff wants to merge 1 commit into
mainfrom
add-custom-player-error-screen
Open

Custom player error screen#234
hfellerhoff wants to merge 1 commit into
mainfrom
add-custom-player-error-screen

Conversation

@hfellerhoff

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

Copy link
Copy Markdown

React Doctor found 1 new issue in 1 file · 1 warning · score 97 / 100 (Great) · 0 fixed · vs main

1 warning

src/components/CustomVideoPlayer/YouTubePlayerErrorOverlay.tsx

  • ⚠️ L31 Button missing explicit type button-has-type

Reviewed by React Doctor for commit 114d965. See inline comments for fixes.

src={`https://img.youtube.com/vi/${videoID}/maxresdefault.jpg`}
/>
</div>
<button

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React Doctor · react-doctor/button-has-type (warning)

Your users can submit the form by accident because a <button> with no type defaults to submit.

Fix → Set an explicit button type so plain buttons do not submit forms by accident: type="button", "submit", or "reset".

Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant