docs: add stateless-validator review checks to REVIEW.md#157
Open
vincent-k2026 wants to merge 1 commit into
Open
docs: add stateless-validator review checks to REVIEW.md#157vincent-k2026 wants to merge 1 commit into
vincent-k2026 wants to merge 1 commit into
Conversation
flyq
approved these changes
Jul 22, 2026
|
|
||
| - Changes to consensus-critical code — EVM execution, witness verification, state root computation, withdrawals — require extra scrutiny. | ||
| - Watch for read-check-write without atomicity (lock, CAS, or database constraint), CPU-intensive work that should use `spawn_blocking` inside async contexts, and deadlocks from nested lock acquisition. | ||
| - **Fail closed on the terminal publish.** The final step (e.g. `mega_setValidatedBlocks`) must not look like success when it permanently failed — surface a non-zero exit / `Err` so the orchestrator detects the miss and retries, instead of advancing while upstream never saw the tip. |
Member
There was a problem hiding this comment.
- Tighten "permanently failed" in rule 1 (
REVIEW.md:20). The codebase deliberately tolerates a failed final report on a chain-following run — the next start re-reports anchor→tip and the miss heals (workers.rs:170-178). Only the slice run fails closed. As written, the rule relies entirely on the word "permanently" to encode that distinction, and the automated reviewer reads this line without theworkers.rscontext — it could flag the deliberately-tolerant chain-following path as a violation. Suggest: "…must not look like success when the run has no later opportunity to retry (e.g. an--end-blockslice run)".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supplements the baseline rubric with stateless-validator-specific checks it doesn't cover:
Err, not silent success.0timeout and unbounded alloc hints before they reach the retry loop.body.contains), with an inter-cycle retry throttle.Additive only — no existing rules changed.