docs(block): correct deposit DA-size tracking comment#342
Open
wayzeek wants to merge 1 commit into
Open
Conversation
The module doc claimed deposit DA sizes are still accumulated into the block DA usage counters for monitoring, but post_execution_update_raw skips deposits (block_da_size_used only accumulates non-deposit txs, per its own test). The spec allows tracking as optional (RFC-2119 MAY); the executor opts out. Update the comment to match the implementation and spec.
wayzeek
requested review from
RealiCZ,
Troublor,
flyq and
vincent-k2026
as code owners
July 16, 2026 20:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
block::limitmodule doc states that deposit DA sizes are "still tracked and accumulated in block DA usage counters for monitoring purposes." The implementation does the opposite:post_execution_update_rawguards the accumulation withif !is_deposit, soblock_da_size_usedonly counts non-deposit transactions (its own unit test,test_post_execution_update_raw_skips_da_for_deposits, asserts this).The spec treats this tracking as optional (
resource-limits.md: DA size "MAY still be tracked for monitoring"), so the executor opting out is fine. This just corrects the comment so it matches the code and spec, and doesn't mislead anyone relying onblock_da_size_usedto reflect the block's full DA weight.No behavior change (comment only).