improve the compose/confirm screens: recipient, full message, overflow arrows#16
Open
roykollensvendsen wants to merge 3 commits into
Open
Conversation
roykollensvendsen
force-pushed
the
feat/confirm-recipient
branch
from
June 24, 2026 17:02
ab7fcd9 to
5a6f127
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small UI improvements around composing and confirming a message.
1. Show the recipient address on confirm
So you can verify who a message is going to before submitting. For a single recipient — a one-off message (
msg_recipient) or a thread reply (the thread's peer) — the confirm prompt's first line showsTo <address>. Channels/groups have no single address, so they keep the plain separator. Reuses the existingfithelper.2. Show every line of a multi-line message on confirm
The preview used to show only the first line. It now shows all lines (capped, with a dim
+N more lines/ char-count summary), and the overlay grows to fit —render_main_panelsizes it from the sameconfirm_previewhelper the renderer uses, so the height always matches the content. Single-line messages look the same as before.3. Show overflow arrows in the composer
When a message has more lines than fit in the input area, the composer scrolls but used to give no hint that lines were hidden. Now the gutter shows
↑on the top visible line when lines are scrolled off above, and↓on the bottom line when there are more below — the vertical counterpart to the existing…for an over-long single line. No extra height used.Tests
e2e harness tests for all three: recipient shown on confirm, a two-line message shows both lines, and the composer shows the up/down arrows when lines are hidden.
cargo fmt --check,cargo clippy --all-targets -- -D warnings, andcargo testall pass.