Fixed some identified bugs#1
Open
nick-cloudfire wants to merge 2 commits into
Open
Conversation
… correctly, ignition circle increased to 30m from 1m
Owner
|
Hi @nick-cloudfire. Thanks for this, but I think you probably want to submit this PR somewhere else. This repo was just a fork that I made a few years ago when working on the farsitebatch code. The original repo no longer seems to be on GitHub, presumably because the Missoula Fire Sciences Laboratory people no longer support or distribute the program. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried to run some test cases when compiling the source (in linux) and encountered some problems. Note that all the code changes were done with/by Claude Code.
There was an odd pointer call that broke make. Removing it helped compile.
There was a check that the input precipitation value was less than 10 inches. The code interpreted the precipitation input value in cm, while the standard for wxs files is in mm. Fixed the conversion factor to work with mm inputs.
The ignition ring vertices were spaced by 1m, which was then immediately wiped by the minimum vertex distance routine, so ignition never spread. Changed the spacing from 1 m (or whatever unit the source geofiles are using) to 30.