fix: enforce generic proxies for unbranded foods#30
Merged
Conversation
Gate exact product identity on user barcode, explicit brand/SKU intent, or exact local identity. Prefer non-branded USDA Foundation/SR Legacy records and label safe branded OFF matches as auditable generic proxies while isolating cache intent. Tests: pytest -q (204 passed); focused resolver/provider/CLI/docs suite (114 passed); ruff check . Smoke: fresh temporary data directory with mocked OFF candidates resolved milk 3%, soy protein isolate, chicken pastrami, whole wheat bread, cream cheese, and peanuts as 6/6 generic_proxy rows with source, candidate brand/barcode, and explicit assumptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exact_producton user barcode, explicit brand/SKU intent, or a local exact pin/alias.Verification
env -u NOMNOM_OFFLINE -u NOMNOM_DB_PATH PYTHONPATH=. pytest -q(204 passed)env -u NOMNOM_OFFLINE -u NOMNOM_DB_PATH ruff check .env -u NOMNOM_OFFLINE -u NOMNOM_DB_PATH PYTHONPATH=. pytest -q -vvtargeted OFF/USDA/policy/literal smoke (12 passed)Closes #29