added json and cbor codecs w/ feature guards#33
Merged
Conversation
Owner
|
I think this is a great idea thanks. Seems like something like this would be best suited as a feature, rather than an entire crate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no stress if you don't want to merge this, but i figured it would be useful to have some common codecs included in the package.
relates to #32, though i believe they are orthogonal (though perhaps it could be called
SerdeBincodeor something rather than justSerdeCodec?). it may be also possible to extract some commonality for serde-based codecs if this is desired, but, i think that is a future task.