docs: correct confirmed factual errors in integration guides#25
Merged
mattglory merged 1 commit intoJun 8, 2026
Merged
Conversation
|
@unixwhisperer is attempting to deploy a commit to the matt glory's projects Team on Vercel. A member of the Team first needs to authorize it. |
mattglory
approved these changes
Jun 7, 2026
mattglory
left a comment
Owner
There was a problem hiding this comment.
Approved. All fixes verified against contract source and live reads. Note: the max-single-loan fix in API_REFERENCE.md, INTEGRATION_GUIDE.md, and TESTING_GUIDE_STX.md overlaps with a commit already on main — you may see a merge conflict there. Everything else is clean and correct. The whitelist curl encoding fix and the is-approved-receiver bare-bool clarification are particularly valuable.
Rebased on current main; the max-single-loan fix already merged upstream is dropped. Remaining verifiable corrections, each checked against contract source, live mainnet reads, or the test suite: - README: STX receiver impl-trait pointed at the wrong contract; corrected to SP3TGRVG7DKGFVRTTVGGS60S59R916FWB4DAB9STZ.stx-flash-receiver-trait (the snippet as written would not deploy) - README: standardize the test count to 82 (matches the badge and `vitest run`: 82 passed) - INTEGRATION_GUIDE: Clarity has no `max` builtin; use the raw-fee / if form - INTEGRATION_GUIDE: the is-approved-receiver read-only call requires a serialized contract principal (0x06...), not the ascii-hex of the string - TESTING_GUIDE_STX: fix the one remaining max-loan figure in the error table (5,000,000,000 -> 500,000,000,000) - TESTING_GUIDE_STX: get-stats field names corrected to total-loans / total-fees - TESTING_GUIDE_STX: STX is-approved-receiver returns a bare bool, not (ok bool) - TESTING_GUIDE_STX: clarify legacy flashstack-core vs live flashstack-sbtc-core
b015b6e to
faf01e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes verifiable documentation errors found during an end-to-end external integration, each checked against contract source, live mainnet reads, or the test suite:
maxbuiltin; use the raw-fee / if formvitest run: 82 passed)Description
Type of Change
Related Issues
Fixes #
Related to #
Changes Made
Testing Performed
Manual Testing
clarinet checkclarinet consoleAutomated Testing
Test Commands Run
# List the commands you ran to test clarinet check clarinet console3Test Results
Checklist
Code Quality
Documentation
Testing
Security & Safety
Screenshots (if applicable)
Additional Context
Deployment Considerations
By submitting this PR, I confirm that: