Refactor to only depend on pymatgen-core#133
Merged
Merged
Conversation
Removed Python 3.10 from the testing matrix.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
==========================================
+ Coverage 79.27% 79.93% +0.66%
==========================================
Files 5 5
Lines 304 324 +20
==========================================
+ Hits 241 259 +18
- Misses 63 65 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
The only failure here is the docs deployment with:
I assume because docs building only works when run on the main branch? |
Collaborator
|
@kavanase thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor refactor so that
pyrhoonly requirespymatgen-coreand not the fullpymatgenpackage.Contributor Checklist
- [ ] I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR