Skip to content

Refactor to only depend on pymatgen-core#133

Merged
jmmshn merged 5 commits into
materialsproject:mainfrom
kavanase:patch-1
May 11, 2026
Merged

Refactor to only depend on pymatgen-core#133
jmmshn merged 5 commits into
materialsproject:mainfrom
kavanase:patch-1

Conversation

@kavanase

@kavanase kavanase commented May 10, 2026

Copy link
Copy Markdown
Contributor

Minor refactor so that pyrho only requires pymatgen-core and not the full pymatgen package.

Contributor Checklist

  • I have run the tests locally and they passed.
    - [ ] I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

@codecov-commenter

codecov-commenter commented May 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.93%. Comparing base (b82e926) to head (3aaf01d).
⚠️ Report is 56 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
+ Coverage   79.27%   79.93%   +0.66%     
==========================================
  Files           5        5              
  Lines         304      324      +20     
==========================================
+ Hits          241      259      +18     
- Misses         63       65       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kavanase

Copy link
Copy Markdown
Contributor Author

The only failure here is the docs deployment with:

Error: Action failed with "not found deploy key or tokens"

I assume because docs building only works when run on the main branch?

@jmmshn

jmmshn commented May 11, 2026

Copy link
Copy Markdown
Collaborator

@kavanase thanks!
I will fix the docs wf

@jmmshn
jmmshn merged commit 58c5bc0 into materialsproject:main May 11, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants