Skip to content

[TASK-tsk_a72447b4][Backend Developer] test: unit tests for package_install team_id parameter#223

Merged
jsyqrt merged 2 commits into
mainfrom
task-tsk_a72447b4
Jun 25, 2026
Merged

[TASK-tsk_a72447b4][Backend Developer] test: unit tests for package_install team_id parameter#223
jsyqrt merged 2 commits into
mainfrom
task-tsk_a72447b4

Conversation

@jsyqrt

@jsyqrt jsyqrt commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

📋 基本信息

  • 提交者: Backend Developer (ID: agt_45ee41456c2a1e988a9c19fd)
  • 关联任务: TASK-tsk_a72447b4
  • 目标分支: main

🎯 背景与动机

为 package_install 工具的 team_id 可选参数支持编写单元测试覆盖。

🔧 变更内容

  • 添加 package_install schema validation tests (team_id optional)
  • 添加 execute handler tests (teamId passthrough, backward compat, whitespace trim)
  • 添加 approval callback tests (team_id in toolArgs)
  • 添加 agent-manager getter tests (teamId fallback)

✅ 验证方式

  • pnpm typecheck (仅测试文件自身无类型错误)
  • pnpm test (36 tests passed)

👤 评审人

  • Reviewer: Code Reviewer

jsyqrt added 2 commits June 25, 2026 22:33
- builder-service.ts: installArtifact/installAgent accept optional teamId
- agent-manager.ts: both installArtifact/hireFromTemplate getters forward teamId
- manager.ts: tool schema + both code paths pass team_id through
@jsyqrt

jsyqrt commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

✅ Code Review — Approved

Reviewer: Code Reviewer

Verification Results

  • pnpm typecheck: ✅ Clean
  • pnpm test: ✅ 36/36 passed (30 in manager-tools.test.ts + 6 in agent-manager-team-id.test.ts)
  • Files changed: 2 (manager-tools.test.ts +77, agent-manager-team-id.test.ts +212)

Test Coverage

manager-tools.test.ts (7 new tests):

  • Schema validation: team_id is optional string
  • Execute passthrough: team_id -> installArtifact(..., teamId)
  • Backward compat: omitted team_id -> undefined
  • Whitespace trim: " team_789 " -> "team_789"
  • hireFromTemplate fallback with team_id
  • Approval callback includes team_id in toolArgs
  • Approval callback without team_id

agent-manager-team-id.test.ts (6 new tests):

  • installArtifact getter passthrough (with/without team_id, whitespace trim)
  • hireFromTemplate getter: explicit teamId, config.teamId fallback, explicit overrides config

Decision

Approved — Ready for Owner merge.

@jsyqrt jsyqrt merged commit 858a840 into main Jun 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant