Skip to content

dedupe: complete a request that deduped nothing, rather than re-queueing it #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthiasgoergens wants to merge 1 commit into
base: master
Choose a base branch
from
Open

dedupe: complete a request that deduped nothing, rather than re-queueing it #416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion dedupe.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,14 @@ static void process_dedupes(struct dedupe_ctxt *ctxt,
req->req_loff += info->bytes_deduped;
req->req_total += info->bytes_deduped;

if (info->status || req->req_total >= ctxt->orig_len) {
/*
* A successful ioctl that deduped nothing has made no
* progress, so re-queueing would resubmit an identical
* request forever. Treat it as complete instead: req_total
* already reflects what was really deduped.
*/
if (info->status || req->req_total >= ctxt->orig_len ||
!info->bytes_deduped) {
/*
* Only bother taking the final status (the
* rest will be 0)
Expand Down