Skip to content

Fix | vs. & logic error on check of retval from stat() #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
klausman wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix | vs. & logic error on check of retval from stat() #406

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d4da67
Fix `|` vs. `&` logic error on check of retval from stat()
klausman Jun 2, 2026
0326c3f
Fix deeper logic error in file_scan stat call checks
klausman Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions file_scan.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ static int get_dirent_type(struct dirent *entry, int fd, const char *path)
* convenience of the caller.
*/
ret = statx(fd, entry->d_name, AT_SYMLINK_NOFOLLOW, STATX_BASIC_STATS, &st);
if (ret || !(st.stx_mask & STATX_BASIC_STATS)) {
if (ret || (st.stx_mask & STATX_BASIC_STATS) != STATX_BASIC_STATS) {
eprintf("Error %d: %s while getting type of file %s/%s. "
"Skipping.\n",
errno, strerror(errno), path, entry->d_name);
Expand Down Expand Up @@ -541,7 +541,7 @@ static int walk_dir(char *path, struct dbhandle *db)
sprintf(child, "%s/%s", path, entry->d_name);

ret = statx(0, child, 0, STATX_BASIC_STATS, &st);
if (ret || !(st.stx_mask | STATX_BASIC_STATS)) {
if (ret || (st.stx_mask & STATX_BASIC_STATS) != STATX_BASIC_STATS) {
eprintf("Failed to stat %s: %s\n",
path, strerror(errno));
continue;
Expand Down Expand Up @@ -731,7 +731,7 @@ int scan_file(char *in_path, struct dbhandle *db)
}

ret = statx(0, path, 0, STATX_BASIC_STATS, &st);
if (ret || !(st.stx_mask & STATX_BASIC_STATS)) {
if (ret || (st.stx_mask & STATX_BASIC_STATS) != STATX_BASIC_STATS) {
eprintf("Error %d: %s while stating file %s. "
"Skipping.\n",
errno, strerror(errno), path);
Expand Down