Always add subagent tool#57
Open
e4t wants to merge 1 commit into
Open
Conversation
|
Connected to Huly®: KIT-58 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
✅ Files skipped from review due to trivial changes (5)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughThis PR clarifies the ChangesSubagent tool initialization and helper
Documentation updates for DisableCoreTools behavior
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@internal/agent/agent.go`:
- Around line 295-297: The comment is inaccurate: when
agentConfig.DisableCoreTools is true and agentConfig.CoreTools is empty the code
sets coreTools = core.SubagentTool(), which provides one subagent tool rather
than zero tools; update the comment above that block to state that it enables
chat-only mode except for the subagent tool (or explicitly mention "one subagent
tool provided via core.SubagentTool()") so the comment matches the behavior of
agentConfig.DisableCoreTools, agentConfig.CoreTools, and coreTools.
In `@internal/core/tools.go`:
- Around line 103-107: The SubagentTool function body uses inconsistent
indentation; open the function containing SubagentTool (and its call to
NewSubagentTool) and reformat the block to use Go's standard tab indentation for
all lines inside the function body so tabs replace any spaces and indentation is
consistent with gofmt; then run gofmt or goimports to ensure the final
formatting is canonical.
In `@README.md`:
- Around line 594-597: The README contains inconsistent documentation about
DisableCoreTools and the --no-core-tools flag: the inline comment for
DisableCoreTools: true says it disables built-in core tools "except for the
subagent tool", while the CLI Reference entry for --no-core-tools lists subagent
as disabled; update the docs to be consistent by clarifying the intended
behavior and making both places match — either change the inline comment for
DisableCoreTools (and mention KIT_NO_CORE_TOOLS / no-core-tools in .kit.yml) to
state that subagent remains enabled, or edit the CLI Reference description for
--no-core-tools to note that subagent is excluded from the disable list,
ensuring both DisableCoreTools, --no-core-tools, KIT_NO_CORE_TOOLS, and
no-core-tools entries use the same phrasing about subagent availability.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: fcb882db-8d83-4b8d-b301-5cdbfb6be061
📒 Files selected for processing (10)
README.mdinternal/agent/agent.gointernal/agent/factory.gointernal/core/subagent.gointernal/core/tools.gointernal/kitsetup/setup.gopkg/kit/README.mdpkg/kit/kit.goskills/kit-sdk/SKILL.mdwww/pages/sdk/options.md
e4t
force-pushed
the
always_add_subagent_tool
branch
from
291f60b to
88d59f8
Compare
The subagent tool is a purely internal tool spawning subagents. It may still be useful even when only chatting to parallelize tasks or when using external (MCP) tools. Signed-off-by: Egbert Eich <[email protected]>
e4t
force-pushed
the
always_add_subagent_tool
branch
from
88d59f8 to
5713314
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update adds the subagent tool even if core tools are disabled. The subagent is purely internal and may be useful to parallelize tasks in chats or when using external MCP tools only.
It can be debated whether an option should be added for this.
Please let me know!
Summary by CodeRabbit