feat(busfactor): per-directory breakdown and knowledge silo detection#166
Open
marcus wants to merge 2 commits into
Open
feat(busfactor): per-directory breakdown and knowledge silo detection#166marcus wants to merge 2 commits into
marcus wants to merge 2 commits into
Conversation
Nightshift-Task: release-notes Nightshift-Ref: https://github.com/marcus/nightshift
Adds --per-directory and --roots flags to `nightshift busfactor` that compute per-component ownership metrics (top-level subdirectories of cmd/ and internal/) and flag any component with bus factor 1 as a knowledge silo. The breakdown is rendered as a markdown table and emitted in JSON output, surfacing where single-contributor risk is hiding inside an otherwise healthy-looking repo. Nightshift-Task: bus-factor Nightshift-Ref: https://github.com/marcus/nightshift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--per-directory(and--roots, defaulting tocmd,internal) tonightshift busfactor. When set, the command walks each immediate subdirectory of the configured roots and computes ownership metrics scoped to that component's git history.component_breakdownfield, sorted with the riskiest entries first.internal/analysis(newListComponentPaths,ComponentMetrics,AnalyzeComponents) andinternal/analysis/report.go(new## Per-Component Bus Factortable); only emitted when the breakdown is populated.Test plan
go vet ./...go build ./...go test ./internal/analysis/... ./cmd/nightshift/...go run ./cmd/nightshift busfactor --per-directory .— confirms 23 silos in this repogo run ./cmd/nightshift busfactor --per-directory --json .— confirmscomponent_breakdownis populatedAutomated by nightshift