Fix Vs code extension#1871
Open
hschne wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1864. Root cause is the upgrade from
vscode-languageserver9.0.1 to 10.0.0.Version 9 exposed its Node.js entry point as a regular file, but Version 10 changed the package to use conditional exports. Its Node.js entry point is now declared roughly like this:
{ "exports": { "./node": { "types": "./lib/node/main.d.ts", "node": "./lib/node/main.js" } } }Rollup's node-resolve plugin does not enable that conditional node export by default. The fix is simply to use
nodeResolve's exportConditions.