Skip to content

Fix Vs code extension#1871

Open
hschne wants to merge 1 commit into
marcoroth:mainfrom
hschne:26-07-fix-vs-code-extension
Open

Fix Vs code extension#1871
hschne wants to merge 1 commit into
marcoroth:mainfrom
hschne:26-07-fix-vs-code-extension

Conversation

@hschne

@hschne hschne commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

This fixes #1864. Root cause is the upgrade from vscode-languageserver 9.0.1 to 10.0.0.

Version 9 exposed its Node.js entry point as a regular file, but Version 10 changed the package to use conditional exports. Its Node.js entry point is now declared roughly like this:

{
  "exports": {
    "./node": {
      "types": "./lib/node/main.d.ts",
      "node": "./lib/node/main.js"
    }
  }
}

Rollup's node-resolve plugin does not enable that conditional node export by default. The fix is simply to use nodeResolve's exportConditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Herb as a VS Code extension: Failing since 0.10.2. Version 0.10.1 works.

1 participant