fix member shadowing warnings#133
Conversation
MSVC treats locals that hide class members as an error under common strict-warning setups (C4458). Rename the block and diagonal bbox locals in indexSegment and intersectsPolygon, and give the Refiner scratch vectors a Vec suffix so the raw pointers cached in refine's hot loop can keep the names used throughout the algorithm.
mourner
left a comment
mourner
left a comment
There was a problem hiding this comment.
Nice! Before we merge this, is there a compilation flag we could pass in CI to catch those issues in the future? Otherwise it's easy to merge the fix this one time but accidentally regress later.
Yep it's |
|
Now failing 4 CI jobs — probably needs fixing or making the flags more granular (e.g. only affecting the source, not tests/bench) |
|
Yep, I see that. Do the tests run automatcially on this repo? Or do I need to kick something? |
|
@skeptopic one failure remaining ( |
|
I think it's going to go green now. But now the commit history is nasty. Do you want me to squash it all into a single commit and re-open? |
|
No worries, GitHub can squash via UI when merging. Thanks for the contribution! |
|
Dude, thank you for this triangulator! It's awesome! |
2 participants
MSVC treats locals that hide class members as an error under common strict-warning setups (C4458).
Rename the block and diagonal bbox locals in
indexSegmentandintersectsPolygon, and give the Refiner scratch vectors aVecsuffix so the raw pointers cached in refine's hot loop can keep the names used throughout the algorithm.