fix: secondary index exclude cutoff handling#184
Merged
Conversation
Do not apply query cutoff while collecting bitmap rows for excluded filters. The bitmap is inverted afterwards, so early cutoff can let excluded values leak through NOT IN queries. Related issue: manticoresoftware/manticoresearch#4640
Linux debug test results 8 files 8 suites 24m 35s ⏱️ Results for commit d48d406. ♻️ This comment has been updated with latest results. |
Linux release test results 8 files 8 suites 8m 51s ⏱️ Results for commit d48d406. ♻️ This comment has been updated with latest results. |
Windows test results 5 files 5 suites 27m 51s ⏱️ Results for commit d48d406. ♻️ This comment has been updated with latest results. |
4 tasks
tomatolog
approved these changes
Jun 23, 2026
tomatolog
left a comment
tomatolog
left a comment
Contributor
There was a problem hiding this comment.
seems good
wait for pass of CI cases after merge into main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not apply query cutoff while collecting bitmap rows for excluded filters. The bitmap is inverted afterwards, so early cutoff can let excluded values leak through NOT IN queries.
Related issue: manticoresoftware/manticoresearch#4640
Related PR in the daemon: manticoresoftware/manticoresearch#4643