Order poker roster, expand distribution cards, add coffee break - #41
Draft
malpou wants to merge 1 commit into
Draft
Order poker roster, expand distribution cards, add coffee break#41malpou wants to merge 1 commit into
malpou wants to merge 1 commit into
Conversation
- roster sorts A-Z, and by card low-to-high once revealed - distribution cards expand to name who played them - anyone can call or end a coffee break in any phase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three planning-poker changes.
Deterministic roster order. Seats sorted A–Z by name (id breaks ties) instead of whatever order the rows came back in, so the list stops jumping between polls. In the revealed phase it re-sorts by the card each seat played — low to high, specials after the numerals, seats with no card last — so the spread reads straight off the roster.
Expandable distribution cards. Each stack under the agreement signal is a native
<details>: card +×countas the summary, the voters' names beneath. No JS, works on touch and keyboard. The landing-page demo passes its four seats through too.Coffee break, any time. New
break_called_bycolumn (migration0015) plus abreakcommand that any token can send in any phase — the ☕ card only reaches the table during a voting round, and a break is a human signal, not a control action. Anyone can call it, anyone can end it; opening the next item or closing the room clears it. Advisory: it blocks nothing.Deploy note: migration
0015_poker_break.sqlneeds applying to remote D1.Spec, colocated Playwright tests and DESIGN.md updated in the same change: new "Call a coffee break" requirement, amended roster-order requirement, 4 new e2e tests, 2 new unit tests. Full suite green (242 e2e, 143 unit).