[INFRA-451] - feat(plane-enterprise): add dbos_worker service#268
Draft
akshat5302 wants to merge 2 commits into
Draft
[INFRA-451] - feat(plane-enterprise): add dbos_worker service#268akshat5302 wants to merge 2 commits into
akshat5302 wants to merge 2 commits into
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Linked to Plane Work Item(s) This comment was auto-generated by Plane |
… drop non-app env sources - Move DBOS_SYSTEM_DATABASE_URL out of the ConfigMap into a dedicated -dbos-worker-secrets Secret, defaulting to the Plane database URL and overridable via external_secrets.dbos_worker_existingSecret. - dbos-worker ConfigMap now holds only DBOS_SYS_DB_POOL_SIZE and DBOS_APP_VERSION. - Deployment envFrom limited to dbos-worker-secrets, dbos-worker-vars, app-vars, and app-secrets; drop doc-store, opensearch, and silo secret references. - values.yaml: add external_secrets.dbos_worker_existingSecret. - README: document DBOS_SYSTEM_DATABASE_URL under dbos_worker_existingSecret and update the values-reference note.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a new opt-in
dbos_workercomponent to theplane-enterprisechart, mirroring the webhook consumer pattern:templates/workloads/dbos-worker.deployment.yaml— deployment running the backend-commercial image with:templates/config-secrets/dbos-worker.yaml—<release>-dbos-worker-varsConfigMap:values.yaml—services.dbos_workerblock (1 replica, 500Mi/250m requests, 1000Mi/500m limits) andenv.dbos_worker_envsdefaultsquestions.yml— new "DBOS Worker Setup" group for the Rancher catalog formREADME.md— new "DBOS Worker Deployment" values tableChart.yaml— version3.0.0→3.1.0Why
The backend is introducing a DBOS-based worker that needs its own long-running deployment with DBOS-specific configuration (system database URL, pool size, app version). This gives operators a first-class chart component for it instead of hand-rolled manifests.
Scope / behavior
services.dbos_worker.enableddefaults tofalse, so nothing renders for existing installs.services.api.image+planeVersion), env sources (app-vars,app-secrets,doc-store-secrets,opensearch-secrets, silo secrets whenservices.silo.enabled), scheduling knobs, security contexts, andextraEnvas the webhook consumer.external_secrets.*_existingSecretoverrides are honored, same as other workloads.Testing
helm lintpasses.helm template --set services.dbos_worker.enabled=truerenders the deployment and ConfigMap with expected values (DBOS_SYSTEM_DATABASE_URL: "",DBOS_SYS_DB_POOL_SIZE: "10",DBOS_APP_VERSION: "v1.0.0"); with defaults (disabled) neither resource renders.phoenixrelease values and applied them to thephoenixnamespace onplane-eks-dev-prime(scaled to 0 pending backend image support); resources created cleanly against the existing release's ConfigMaps/Secrets.Related
🤖 Generated with Claude Code