fix(fileutils): accept os.PathLike in AtomicSaver - #416
Merged
Conversation
Owner
|
Good call, pathlib support here was overdue. Thanks for the fix + tests! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AtomicSaver.__init__assigneddest_pathdirectly toself.dest_pathand later concatenated it as a string (dest_path + '.part'), which raisesTypeErrorwhen apathlib.Pathis passed.iter_find_filescalled.split()on thedirectoryargument, which also fails forpathlib.Path.Changes:
AtomicSaver.__init__: convertdest_pathviaos.fspath()at the top of the method, and useself.dest_path(the already-converted str) when building the.partpathiter_find_files: convertdirectoryviaos.fspath()before calling.split()test_atomicsaver_pathlikeandtest_iter_find_files_pathliketo the test suiteCloses #383