fix: mis-parse of leading integer + space + unicode fraction#1
Open
akrigline wants to merge 1 commit into
Open
fix: mis-parse of leading integer + space + unicode fraction#1akrigline wants to merge 1 commit into
akrigline wants to merge 1 commit into
Conversation
"1 ¼ cups milk" lost its unit and left a stray "1" in the ingredient text, because unicodeFractionRegex only absorbed a digit into the match when it was directly adjacent to the fraction glyph. Adding \s* between them lets it also match "1 ¼" so the leading integer is correctly stripped from the remainder before unit parsing runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer if you care: Claude Code did a lot of the legwork on this. I noticed the issue working on a different project and figured I'd open a PR with its help.
Summary
Copying ingredients lists from allrecipies, I encountered lines like
1 ¼ cups milk."1 ¼ cups milk" lost its unit and left a stray "1" in the ingredient text, because unicodeFractionRegex only absorbed a digit into the match when it was directly adjacent to the fraction glyph.
Adding
\s*between them lets it also match "1 ¼" so the leading integer is correctly stripped from the remainder before unit parsing runs.Demonstrated by the new unit test
Without fix:
Type of Change
Checklist
bun run lint && bun run typecheck && bun run test)