Use add-function to append process filter instead of replacing it#138
Merged
Conversation
When `async-shell-command-display-buffer' is nil, the display of the shell command buffer is delayed until there is output. This is achieved by adding a function to the process filter. Previously we replaced that filter, which prevented the intended delayed display. Use `add-function' to append our filter instead. Co-authored-by: Jonas Bernoulli <[email protected]> Decision to drop support for Emacs 26 and 27, so `add-function' can be used.
Member
|
Thanks! |
Contributor
Wasn't (Not super important regardless, I'm just updating my setup right now and going through old revisions of packages I use) |
Member
|
Yes it was. Emacs 28 is actually needed for the unrelated commit right before this one. Got confused there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
async-shell-command-display-bufferis nil, the display of theshell command buffer is delayed until there is output. This is
achieved by adding a function to the process filter. Previously we
replaced that filter, which prevented the intended delayed display.
Use
add-functionto append our filter instead.