feat(stack)!: upgrade to v4#310
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Sqitch migration scripts and supporting tooling to match the v4 stack change where Docker secret filenames use dashes (-) instead of underscores (_). This keeps deploy/revert/verify flows, local src/sqitch Docker runner mounts, and CI benchmarking aligned with the new secret naming convention.
Changes:
- Renamed all referenced
/run/secrets/*paths from underscore-separated to dash-separated across deploy/revert/verify SQL scripts. - Updated local Docker runner mounts (
src/sqitch) to bind the newly named secret files from the stack repo into/run/secrets/. - Updated container/CI wiring (
Dockerfile,docker-entrypoint.sh, and benchmark workflow) to use the new secret filenames.
Reviewed changes
Copilot reviewed 73 out of 73 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/verify/table_upload_policy.sql | Update secret path to dashed filename. |
| src/verify/table_report.sql | Update secret path to dashed filename. |
| src/verify/table_profile_picture.sql | Update secret path to dashed filename. |
| src/verify/table_preference_event_size.sql | Update secret path to dashed filename. |
| src/verify/table_preference_event_location.sql | Update secret path to dashed filename. |
| src/verify/table_preference_event_format.sql | Update secret paths (reccoom/vibetype) to dashed filenames. |
| src/verify/table_preference_event_category.sql | Update secret paths (reccoom/vibetype) to dashed filenames. |
| src/verify/table_legal_term.sql | Update secret path to dashed filename. |
| src/verify/table_legal_term_acceptance.sql | Update secret path to dashed filename. |
| src/verify/table_jwt.sql | Update secret path to dashed filename. |
| src/verify/table_guest_policy.sql | Update secret path to dashed filename. |
| src/verify/table_friendship.sql | Update secret path to dashed filename. |
| src/verify/table_event_upload.sql | Update secret path to dashed filename. |
| src/verify/table_event_recommendation.sql | Update secret path to dashed filename (plus formatting normalization). |
| src/verify/table_event_policy.sql | Update secret paths (reccoom/vibetype) to dashed filenames. |
| src/verify/table_event_format.sql | Update secret paths (reccoom/vibetype) to dashed filenames. |
| src/verify/table_event_format_mapping.sql | Update secret paths (reccoom/vibetype) to dashed filenames. |
| src/verify/table_event_favorite.sql | Update secret path to dashed filename. |
| src/verify/table_event_category.sql | Update secret paths (reccoom/vibetype) to dashed filenames. |
| src/verify/table_event_category_mapping.sql | Update secret paths (reccoom/vibetype) to dashed filenames. |
| src/verify/table_device.sql | Update secret path to dashed filename. |
| src/verify/table_contact_policy.sql | Update secret path to dashed filename. |
| src/verify/table_address_policy.sql | Update secret path to dashed filename. |
| src/verify/table_achievement.sql | Update secret path to dashed filename. |
| src/verify/table_achievement_code.sql | Update secret path to dashed filename. |
| src/verify/table_account_public_policy.sql | Update secret path to dashed filename. |
| src/verify/table_account_private.sql | Update secret path to dashed filename. |
| src/verify/table_account_block.sql | Update secret paths (reccoom/vibetype) to dashed filenames. |
| src/verify/schema_public.sql | Update secret paths (reccoom/vibetype) to dashed filenames. |
| src/verify/role_zammad.sql | Update secret path to dashed filename. |
| src/verify/role_vibetype.sql | Update secret path to dashed filename. |
| src/verify/role_reccoom.sql | Update secret path to dashed filename. |
| src/verify/role_postgraphile.sql | Update secret path to dashed filename. |
| src/verify/role_grafana.sql | Update secret path to dashed filename. |
| src/verify/role_anonymous.sql | Update secret path to dashed filename. |
| src/verify/role_account.sql | Update secret path to dashed filename. |
| src/verify/function_invoker_account_id.sql | Update secret path to dashed filename. |
| src/sqitch | Update bind mounts to dashed secret filenames from stack repo into /run/secrets/. |
| src/revert/table_event_policy.sql | Update secret path to dashed filename. |
| src/revert/role_zammad.sql | Update secret path to dashed filename. |
| src/revert/role_vibetype.sql | Update secret path to dashed filename. |
| src/revert/role_reccoom.sql | Update secret path to dashed filename. |
| src/revert/role_postgraphile.sql | Update secret path to dashed filename. |
| src/revert/role_grafana.sql | Update secret path to dashed filename. |
| src/deploy/table_upload_policy.sql | Update secret path to dashed filename. |
| src/deploy/table_profile_picture.sql | Update secret path to dashed filename. |
| src/deploy/table_preference_event_format.sql | Update secret path to dashed filename. |
| src/deploy/table_preference_event_category.sql | Update secret path to dashed filename. |
| src/deploy/table_notification.sql | Update secret path to dashed filename. |
| src/deploy/table_event_policy.sql | Update secret path to dashed filename. |
| src/deploy/table_event_format.sql | Update secret path to dashed filename. |
| src/deploy/table_event_format_mapping.sql | Update secret path to dashed filename. |
| src/deploy/table_event_category.sql | Update secret path to dashed filename. |
| src/deploy/table_event_category_mapping.sql | Update secret path to dashed filename. |
| src/deploy/table_device.sql | Update secret path to dashed filename. |
| src/deploy/table_achievement_code.sql | Update secret path to dashed filename. |
| src/deploy/table_account_private.sql | Update secret path to dashed filename. |
| src/deploy/table_account_block.sql | Update secret path to dashed filename. |
| src/deploy/schema_public.sql | Update secret paths (reccoom/vibetype) to dashed filenames. |
| src/deploy/schema_private.sql | Update secret path to dashed filename. |
| src/deploy/role_zammad.sql | Update secret paths (username/password) to dashed filenames. |
| src/deploy/role_vibetype.sql | Update secret paths (username/password/postgraphile username) to dashed filenames. |
| src/deploy/role_reccoom.sql | Update secret paths (username/password) to dashed filenames. |
| src/deploy/role_postgraphile.sql | Update secret paths (username/password) to dashed filenames. |
| src/deploy/role_grafana.sql | Update secret paths (username/password) to dashed filenames. |
| src/deploy/role_anonymous.sql | Update secret path to dashed filename. |
| src/deploy/role_account.sql | Update secret path to dashed filename. |
| src/deploy/function_invoker_account_id.sql | Update secret path to dashed filename. |
| src/deploy/database_zammad.sql | Update secret path to dashed filename. |
| src/deploy/database_grafana.sql | Update secret path to dashed filename. |
| Dockerfile | Switch to dashed secret filenames (incl. POSTGRES_PASSWORD_FILE) and update seeded /run/secrets/* test fixtures. |
| docker-entrypoint.sh | Read SQITCH_TARGET from /run/secrets/sqitch-target (dashed name). |
| .github/workflows/benchmark.yml | Create dashed role secret files in /run/secrets/ for benchmark runs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dargmuesli
marked this pull request as ready for review
July 12, 2026 05:26
|
🎉 This PR is included in version 12.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Secrets now use dashes (
-) instead of underscores (_) as separators.