feat: Eigenvalue based checks for +ve definiteness#963
Draft
henry-wallace-phys wants to merge 12 commits into
Draft
feat: Eigenvalue based checks for +ve definiteness#963henry-wallace-phys wants to merge 12 commits into
henry-wallace-phys wants to merge 12 commits into
Conversation
|
Hi @henry-wallace-phys, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this Use this action on your projects. Use jokes on issues instead. |
Super-linter summary
All files and directories linted successfully For more information, see the GitHub Actions workflow run Powered by Super-linter |
|
Hi, I am MaCh3-Telemetry bot Memory and CPU Usage SummaryMemory Usage PlotYou can view the memory usage plot directly in the job summary from the link above. |
henry-wallace-phys
marked this pull request as draft
July 2, 2026 14:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pull request description
Adds a diagnostic to +ve definite code that checks negative eigenvalues + prints out the main contributions
Requires PR: #962
Changes or fixes
MakeMatrixPosDefto take optional parameter names argumentExamples
On DUNE [slightly different to the committed version which has typos fixed + is a warning not an error]: