feat(mach): parse minimum macOS version from load commands (fixes #514)#536
Closed
wyf027 wants to merge 2 commits into
Closed
feat(mach): parse minimum macOS version from load commands (fixes #514)#536wyf027 wants to merge 2 commits into
wyf027 wants to merge 2 commits into
Conversation
Add MacOSVersion with packed-version parsing, helpers on LC_VERSION_MIN_MACOSX / LC_BUILD_VERSION, and MachO::min_macos_version() (fixes #514). Co-authored-by: Cursor <[email protected]>
Contributor
Author
|
Resolved the rustfmt CI failure in commit 3a17801 by applying the formatter to src/mach/mod.rs. Local verification: cargo fmt -- --check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MacOSVersionwithfrom_packed()for Mach-Oxxxx.yy.zzversion encoding.VersionMinCommand::macos_min_version()andBuildVersionCommand::macos_min_version().MachO::min_macos_version()scanningLC_VERSION_MIN_MACOSXand macOSLC_BUILD_VERSION, returning the highest minimum version found.Fixes #514.
Test plan
cargo test macos_versioncargo test --lib