this change will pass at first but will result in silent merge#9
Merged
Conversation
This was referenced May 27, 2026
m3dwards
force-pushed
the
master
branch
2 times, most recently
from
df16346 to
c107e07
Compare
m3dwards
force-pushed
the
250910-silent-merge-test-pr3
branch
from
6686520 to
92820eb
Compare
m3dwards
force-pushed
the
master
branch
3 times, most recently
from
393dc8a to
2ce4ae7
Compare
m3dwards
force-pushed
the
master
branch
2 times, most recently
from
393dc8a to
f56a62e
Compare
`CalculateMaximumSignedInputSize()` is passed the outpoint being sized, but that context was not used when estimating the signed input size. Pass the outpoint through so externally selected inputs are not underestimated. Co-authored-by: Antoine Poinsot <[email protected]>
m3dwards
force-pushed
the
250910-silent-merge-test-pr3
branch
from
92820eb to
0d57341
Compare
m3dwards
force-pushed
the
master
branch
4 times, most recently
from
b4074d9 to
055f6fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be fine as a PR but when it's merged into master it will cause a silent merge conflict with #5