Implement SegmentPool for all platforms.#1776
Open
MohammedKHC wants to merge 1 commit into
Open
Conversation
MohammedKHC
force-pushed
the
native-pool
branch
4 times, most recently
from
February 10, 2026 13:54
ebe7306 to
8036bf2
Compare
MohammedKHC
force-pushed
the
native-pool
branch
from
April 24, 2026 01:21
8036bf2 to
5e41e67
Compare
swankjesse
reviewed
Jul 20, 2026
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright (C) 2014 Square, Inc. | |||
| * Copyright (C) 2026 Square, Inc. | |||
Collaborator
There was a problem hiding this comment.
As a practice we don’t change these numbers
| */ | ||
| internal expect object SegmentPool { | ||
| val MAX_SIZE: Int | ||
| @OptIn(ExperimentalAtomicApi::class) |
Collaborator
There was a problem hiding this comment.
We can’t do this in Okio
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1629
Questions
jssource set should be shared withwasmJs. Is there any reason this isn’t the case? I believewasmJsshould have access to the Node.js and browser APIs.AtomicReference? (currently it requires opting in toExperimentalAtomicApi)On the JVM, it just maps to
java.util.concurrent.atomic.AtomicReferenceanyway.