feat(builder): accept and forward the dev-server hmr option (#145) - #188
Merged
lukekania merged 2 commits intoJun 10, 2026
Merged
Conversation
The Rust side of HMR landed in PRs #185-#187, but the Architect builder still rejected `hmr` at schema validation (additionalProperties: false) and never forwarded a flag, so `ng serve` users could not reach it. - schemas/dev-server.json: declare `hmr` (boolean, no default) - serve/options.ts: tri-state forwarding — true → --hmr, false → --no-hmr, unset → nothing (binary inherits architect.serve.options.hmr from angular.json)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the builder-side gap in #145. The Rust implementation of HMR landed in #185/#186/#187, but the Architect builder still rejected the
hmroption at schema-validation time (additionalProperties: falseindev-server.json) and never forwarded a flag — song serveusers could not reach any of it.ngc-rs serve --hmrworked;ng servewithhmr: truehard-failed.Changes
packages/builder/schemas/dev-server.json: declarehmr(boolean, no default).packages/builder/src/serve/options.ts: tri-state forwarding —hmr: true→--hmr,hmr: false→--no-hmr, unset → no flag, letting the binary inheritarchitect.serve.options.hmrfrom angular.json (its existing fallback).serve/__tests__/options.test.ts(28 passing).chore: version bump to 0.10.18.Verification (test-ng-project, via the builder)
hmr: truein serve options: schema accepts it, spawned binary logsngc-rs HMR enabled, served page contains the HMR runtime.src/styles.scssemitscss-updateover SSE (no reload).src/app/app.htmlemitsangular:component-updateforApp(no reload).ng serve --no-hmroverrideshmr: truefrom angular.json (no HMR banner) — CLI passthrough via the schema works both ways.