Clarify toRoutingHint behavior in README documentation#14
Conversation
"toRoutingHint is eight lines" is a magic number that goes stale the moment
the function changes. Replace it with what the function actually does — drop
the note's text — which is the durable point and echoes no-leak.ts's own
comment ("the only thing it does is throw the text away").
https://claude.ai/code/session_01113o5Rz53CzEJhqraQrRid
Automated Checks (advisory, non-blocking)✅ All checks passed. Standards ComplianceNo standards violation is apparent from the PR description: this is a README-only clarification, and the behavior being documented ( One thing worth verifying in the README wording itself: make sure the clarification stays consistent with the full no-leak story from the standards, i.e. it reinforces SummaryThis looks like a documentation-only PR that sharpens the explanation of What to pay attention to
Things I noticedIf the README now explicitly says No red flags are visible from the provided materials; this appears to be a low-risk doc clarification. Good patterns
Suggested improvements
Questions for the author
Surmado Code Review (v1.2-mt) is an automated review, designed to work alongside human judgment. Want to change your STANDARDS.md or YML? Edit it directly, or tune it with our AI agent Scout. Comment |
Summary
Updated the README documentation to more clearly explain what the
toRoutingHintfunction does and why it's important for maintaining privacy boundaries in the system.Changes
src/no-leak.tsto explicitly state thattoRoutingHintdrops the note's textRoutingHinttype's shape (which has no text field) rather than relying on runtime guardsDetails
The change emphasizes that the security model depends on the type system itself: since
RoutingHinthas no field for note text, it's structurally impossible for private prose to leak to the model. This is a more precise explanation of why the small, auditabletoRoutingHintfunction is critical to the system's privacy guarantees.https://claude.ai/code/session_01113o5Rz53CzEJhqraQrRid