chore(l10n): translator hints for cancelled appointments (Abgesagt, nicht Abgebrochen)#115
Merged
Conversation
'Cancelled' means the appointment was called off (German 'Abgesagt',
not 'Abgebrochen') — hints on the status badge, list filter and group,
the cancel/reactivate menu action, success toast, mobile strings and
the iCal title prefix, distinguishing it from the generic dialog
button 'Cancel' ('Abbrechen').
Verified against the Nextcloud translationtool: a TRANSLATORS comment only attaches to the first t() call on the immediately following line. Multi-line ternaries, multi-line attribute bindings and comments before an element tag silently lose their hint, and the second call of a one-line ternary never gets one. Restructure the affected spots: scheduling toggle label/tooltip and cancel/reactivate action become computeds/functions with one comment per t() line, check-in chips get computed texts, the cancel toast an if/else, the cancelled badge and the teams settings section move the translated attribute onto the line after the comment. Document the binding rule and a local verification workflow (translationtool via docker + grep of the generated .pot) in the transifex skill.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
TRANSLATORS context hints (comments only, no string/key changes) on every string of the cancelled-appointment family: the status badge and list filter/group label (
Cancelled), theCancel appointment/Reactivate appointmentmenu action, theAppointment cancelledsuccess toast, the mobile strings (Cancelled on {when},This appointment has been cancelled.) and the iCal title prefix.Why
The strings mean the appointment was called off — German „Abgesagt"/„Termin absagen". Translators rendered several of them as „Abgebrochen"/„Termin abbrechen" (currently
Cancelled→ „Abgebrochen",Cancelled on {when}→ „Abgebrochen am {when}",Cancel appointment→ „Termin abbrechen" in de and de_DE), most likely because the generic dialog buttonCancel(correctly „Abbrechen") looks identical without context. The hints spell out the distinction for all languages; a matching Transifex issue asks for the German fixes.Notes for review
npm run buildandcomposer test:unit(155 tests) pass.🤖 Generated with Claude Code