Skip to content

DM-50124: Add rename to dict to ImportIR - #508

Closed
taranu wants to merge 1 commit into
mainfrom
tickets/DM-50124
Closed

DM-50124: Add rename to dict to ImportIR#508
taranu wants to merge 1 commit into
mainfrom
tickets/DM-50124

Conversation

@taranu

@taranu taranu commented Jul 28, 2025

Copy link
Copy Markdown
Contributor

Checklist

  • ran Jenkins
  • ran and inspected package-docs build
  • added a release note for user-visible changes to doc/changes

@codecov

codecov Bot commented Jul 28, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 34.78261% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.75%. Comparing base (185ea4b) to head (ffcfee8).
⚠️ Report is 57 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
python/lsst/pipe/base/pipelineIR.py 34.78% 12 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
- Coverage   83.83%   83.75%   -0.08%     
==========================================
  Files         114      114              
  Lines       14736    14757      +21     
  Branches     1906     1912       +6     
==========================================
+ Hits        12354    12360       +6     
- Misses       1929     1941      +12     
- Partials      453      456       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@taranu
taranu force-pushed the tickets/DM-50124 branch from 4555b3c to c8cc53e Compare July 28, 2025 20:53
@taranu
taranu force-pushed the tickets/DM-50124 branch from c8cc53e to ffcfee8 Compare July 28, 2025 21:03
"""list of tasks that should be excluded when inheriting this pipeline.
Either the include or exclude attributes may be specified, but not both.
"""
rename: dict[str, str] | None = None

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could clean up the logic later by defining this as

rename: dict[str, str] = dataclasses.field(default_factory=dict)

since in this case (unlike include and exclude) None behaves like an empty dict.

@taranu

taranu commented Aug 12, 2025

Copy link
Copy Markdown
Contributor Author

I'm moving this to DM-52168.

@taranu taranu closed this Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants