DM-50124: Add rename to dict to ImportIR - #508
Closed
taranu wants to merge 1 commit into
Closed
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
==========================================
- Coverage 83.83% 83.75% -0.08%
==========================================
Files 114 114
Lines 14736 14757 +21
Branches 1906 1912 +6
==========================================
+ Hits 12354 12360 +6
- Misses 1929 1941 +12
- Partials 453 456 +3 ☔ View full report in Codecov by Sentry. |
TallJimbo
reviewed
Jul 29, 2025
| """list of tasks that should be excluded when inheriting this pipeline. | ||
| Either the include or exclude attributes may be specified, but not both. | ||
| """ | ||
| rename: dict[str, str] | None = None |
Member
There was a problem hiding this comment.
I think you could clean up the logic later by defining this as
rename: dict[str, str] = dataclasses.field(default_factory=dict)
since in this case (unlike include and exclude) None behaves like an empty dict.
Contributor
Author
|
I'm moving this to DM-52168. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
package-docs builddoc/changes