DM-55220: add accessors for template provenance to CoaddPsf - #479
Conversation
Const accessors should be marked as such. SkyWcs is immutable and should be passed by shared_ptr<SkyWcs> or shared_ptr<SkyWcs const> (doesn't matter which) to avoid unnecessary copies.
In the DIA template_detector, we already store the IDs of the tract and patch of each template coadd in the CoaddPsf, but there is no way to access these.
isullivan
left a comment
isullivan
left a comment
There was a problem hiding this comment.
Only one issue, which is that it looks like getTract and getPatch can't get their tract and patch values.
| int getTract(int index) const; | ||
|
|
||
| /** | ||
| * Get the patch ID of the component image at the given index. | ||
| * | ||
| * @throws lsst::pex::exceptions::NotFoundError There is no patch column. | ||
| */ | ||
| int getPatch(int index) const; |
There was a problem hiding this comment.
I don't see how getTract and getPatch actually get set. src/CoadPsf.cc initializes with a minimal schema, which does not include patch or tract columns, so it looks like the exposure catalog won't actually have tract or patch columns.
There was a problem hiding this comment.
There are a few different constructors for CoaddPsf, and you're right about most of them. But there's one - the one we actually use in GetTemplateTask - that provides more control over the schema.
From the perspective of CoaddPsf, this usage was not expected or intentional. But it happens to be where we've stuffed a lot of useful information in all of the DP2 files. I am looking forward to being able to replace it with something more intentional in the future when we make GetTemplateTask write an lsst.images output directly.
2 participants
No description provided.