DM-55017-v30: Add accommodations for crowded fields in coadd assembly and detection - #477
Closed
laurenam wants to merge 13 commits into
Closed
DM-55017-v30: Add accommodations for crowded fields in coadd assembly and detection#477laurenam wants to merge 13 commits into
laurenam wants to merge 13 commits into
Conversation
DM-53695-v30: Make interpolation code nan-safe by inverting min checks.
This guards against potentially very long (or infinite) running loops. Also adds a unittest check that forces entry into this loop to make sure it iterates just two times, having set the full images as having the DETECTION mask set, and checking that it fails at trying to lay down sky sources.
DM-54009: Drop streak line models that are off the image
DM-53313-v30: Check for very small change in chi2
DM-54947-v30: Add reset method to AccumulatorMeanStack.
In the "bright" detection phase of the dynamic detection task, we have encountered cases where a very large fraction of the pixels are marked with DETECTED_NEGATIVE. This seems to be due to background over-subtraction in crowded fields (where this pathology is most significant). This adds a guard against such cases by imposing a maximum allowed fraction of DETECTED_NEGATIVE pixels (in addition to an independent maximum allowed fraction of DETECTED pixels in this pass). If this maximum is exceeded, the detection threshold is iteratively increased until it falls below the threshold.
This fixes a bug where the override was getting ingored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.